From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06949C7619A for ; Wed, 12 Apr 2023 06:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KEg679iD/UhzaJNqPa5DUUVEPXBDauxIrW1y3byuoqc=; b=aL/XJtG7n81CvX lHVE73/OYIpWQ0gZmb3L4T9GNnqfMRO1s5RvT8OU+Sth8G/nqtzZ5BrhLkiQm2a4j4BNoT4k+6Bzj /04f3Z3iLGhNUkssBG+KhG/r8LrlYL3bQ+uWfM2lga6Z9TzTJKMiKbX0KLlZZ3BTSv/3ojAGzwGwb EVKVuQN9ryh4yTI/0vG8NStZc4LDwpneSv7EyzO0jt8L6cVgQwKVkgtlTj0WTPd9SxzBGGrY1T9KS yRWxrfigtrHLvJHfc6oDyiRhaS/vTrl7/xCk836YKE5alTVMheyWPNpkFU5Juei14lkaBMEsf6Y/n XW3WjhvYp7Mqg2VMBSKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmTks-001uoC-2B; Wed, 12 Apr 2023 06:14:54 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmTkp-001unQ-0v for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 06:14:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D6DB62854; Wed, 12 Apr 2023 06:14:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41DEBC433EF; Wed, 12 Apr 2023 06:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681280089; bh=Nxag8wK1torwvwcelmJg4s5Xft+8uu3sHSeDBkA6DIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z0C6JC868/IbrDNImk0zmIaQYLikuOeSr4okyyqgL6WyPuWoITU2J28J+4gTwO+SY jFrJtF+QfNU/XlnmM4Nhdsz4nmpnkBZ/+pLXtdK70Z+gdKrDmYTCVTx0pkbmgg884h k5jrVjHTZLUx8nxkSGxiaQnavKN3Whh5Zk7hTVZ8= Date: Wed, 12 Apr 2023 08:14:47 +0200 From: Greg Kroah-Hartman To: John Moon Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Jordan Crouse , Trilok Soni , Satya Durga Srinivasu Prabhala , Elliot Berman , Guru Das Srinagesh Subject: Re: [PATCH v5 1/2] check-uapi: Introduce check-uapi.sh Message-ID: <2023041209-armed-overlaid-3d3d@gregkh> References: <20230407203456.27141-1-quic_johmoo@quicinc.com> <20230407203456.27141-2-quic_johmoo@quicinc.com> <2023041015-lunar-dandelion-1b4e@gregkh> <2023041136-donator-faceplate-5f91@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_231451_364963_22D7D808 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 11, 2023 at 11:36:48AM -0700, John Moon wrote: > > > > > > Others do not seem to be intentional: > > > > > > Addition/use of flex arrays: > > > - include/uapi/linux/rseq.h (f7b01bb0b57f) > > > - include/uapi/scsi/scsi_bsg_mpi3mr.h (c6f2e6b6eaaf) > > > > That is not a breakage, that's a tool problem. > > > > > Type change: > > > - include/uapi/scsi/scsi_bsg_ufs.h (3f5145a615238) > > > > Again, not a real breakage, size is still the same. > > > > Would you find the tool more useful if it simply filtered out all instances > where the size of the type did not change? This would filter out the > following which the tool currently flags: > > - enum expansions > - reserved field expansions > - expansions of a struct with a flex array at the end > - type changes > - re-ordering of existing members > - ...others? Obviously not, as some of those are real breakages, and some are not at all. Please understand what is an abi breakage. Adding new enums is not. Using a reserved field is not. Reording existing members IS. > These changes aren't _always_ safe, but if you assume the kernel developer > is doing something reasonable, then maybe it's okay. Maybe we could hide > these checks behind something like a "--pedantic" flag? Again, no, that list above has totally different things in it, some are completly safe, others totally break the abi. Do NOT lump them all together as that is wrong. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel