From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0914C77B6E for ; Wed, 12 Apr 2023 13:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XaQGt3S/DqqMmcnDzy5cd0Zk7cUBwXL1v4vdDfLBteg=; b=eyiwA/WYjpSKSY 2ka80TxrN4EEI/twiOcTjTd8AI+1jEpeir9o+um8a1bfNT/tUrQ3LN9h8bVhEjkEfMi0vsdS2BJQj Mh58+jxXJLSh7WxISX+jxXJo0jK2Sro4afHWdgSz58ea/fddNDiXotva9xqH2bRAVUALls3KMMmPh MuRnKdaJzdBi9JVCA4DR6Nriqis3h2TUFcY4+0b3JTVVyrxCDt2FAL2Rax6ira3m4koinVBD4tPi6 OHE7F9uEOqXklcscdbUfFpI/j2Z2obBBwmo+zZ51L77Lv2keXMXPsGgPo65O5g0MueSAxxD7ROWi9 djTRfM1xrC+I+aI0qZDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmaJr-003Itm-2W; Wed, 12 Apr 2023 13:15:27 +0000 Received: from mail-ot1-f44.google.com ([209.85.210.44]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmaJn-003Irb-2z for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 13:15:25 +0000 Received: by mail-ot1-f44.google.com with SMTP id bu14-20020a0568300d0e00b0069fab3f4cafso5419687otb.9 for ; Wed, 12 Apr 2023 06:15:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681305323; x=1683897323; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MFD7NhK2n6LRm3/Y/zZUZpldkUwIJ0dQh6NwA4X/4ww=; b=nlF95GaaxGY+7oztC3hnz9hEZI35K7JN6/YOKTO4O4+qXGor2DZIHZff+YYD1ZLFz/ hePZZhZ9ZX4wXVBMfi4vTEJjFkaRAm0mk7N7VgcSWgExQ6+tHtmUthzC8kKIBhehYqID Qt2M36cyX1Rourw0rEjRfpVhhrJXGGCA22Y+3TxNLVYVqmJc4IPi8OOBEb52QqVb7Rsk S0KGUHgD/2p3N6cBzjzp2ypVt/PI7stz8B0PHsCVLQiUctFu5BG1jNmCZzyR3wft1REC 9e+FVuG1VJBBgpaiV2pHfOcEsEKnb0Tk7R6E1uj5WnCSERVl7kgPhMyRmyhmlvxWLs/L atRg== X-Gm-Message-State: AAQBX9d2fCqvgvqIzd8Gh2U1ZWE4kgGnWy/fYgqSgf3d0XRklGlVg6SW YtScVdMDrXeFLrcVcVcLqQ== X-Google-Smtp-Source: AKy350b0BHjuZKDnNLiWFaaVgnwX0CY+gcQNzPwHkH+YHkjo7NjmIWxl00hy3X6ub0x9YQkKf31V/g== X-Received: by 2002:a9d:7586:0:b0:69f:8e11:ff36 with SMTP id s6-20020a9d7586000000b0069f8e11ff36mr8704748otk.33.1681305322844; Wed, 12 Apr 2023 06:15:22 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c17-20020a056830001100b006a2e9ccb42esm6413802otp.19.2023.04.12.06.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 06:15:22 -0700 (PDT) Received: (nullmailer pid 1917201 invoked by uid 1000); Wed, 12 Apr 2023 13:15:21 -0000 Date: Wed, 12 Apr 2023 08:15:21 -0500 From: Rob Herring To: Cristian Marussi Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, nicola.mazzucato@arm.com, Tushar.Khandelwal@arm.com, viresh.kumar@linaro.org, jassisinghbrar@gmail.com, Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: mailbox : arm,mhuv2: Allow for more RX interrupts Message-ID: <20230412131521.GA1830888-robh@kernel.org> References: <20230329153936.394911-1-cristian.marussi@arm.com> <20230329153936.394911-2-cristian.marussi@arm.com> <20230329174431.yga3c233sazimane@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_061523_961879_EC4FC6C5 X-CRM114-Status: GOOD ( 40.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 30, 2023 at 09:29:23AM +0100, Cristian Marussi wrote: > On Wed, Mar 29, 2023 at 06:44:31PM +0100, Sudeep Holla wrote: > > On Wed, Mar 29, 2023 at 04:39:35PM +0100, Cristian Marussi wrote: > > > The ARM MHUv2 Receiver block can indeed support more interrupts, up to the > > > maximum number of available channels, but anyway no more than the maximum > > > number of supported interrupt for an AMBA device. > > > > > > Signed-off-by: Cristian Marussi > > > --- > > > Cc: Rob Herring > > > Cc: Krzysztof Kozlowski > > > Cc: devicetree@vger.kernel.org > > > > > > .../devicetree/bindings/mailbox/arm,mhuv2.yaml | 13 +++++++++---- > > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > > > index a4f1fe63659a..5a57f4e2a623 100644 > > > --- a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > > > +++ b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > > > @@ -69,10 +69,15 @@ properties: > > > > > > interrupts: > > > description: | > > > - The MHUv2 controller always implements an interrupt in the "receiver" > > > - mode, while the interrupt in the "sender" mode was not available in the > > > - version MHUv2.0, but the later versions do have it. > > > - maxItems: 1 > > > + The MHUv2 controller always implements at least an interrupt in the > > > + "receiver" mode, while the interrupt in the "sender" mode was not > > > + available in the version MHUv2.0, but the later versions do have it. > > > + In "receiver" mode, beside a single combined interrupt, there could be > > > + multiple interrupts, up to the number of implemented channels but anyway > > > + no more than the maximum number of interrupts potentially supported by > > > + AMBA. > > > + minItems: 1 > > > + maxItems: 9 > > > > Hi, > > > I am not sure 9 is the correct value here. IIUC it is just what Linux defines > > as AMBA_NR_IRQS. Looking at the history it was bumped from 2 to 9 for use > > by PL330 DMA driver. I couldn't find anything to relate this 9 in any > > AMBA or other related specification. > > > > Yes, I could not find either where the 9 comes from, but it is what > currently each amba device is limited to, at the software level, in terms of > interrupts that can be detected. IIRC, the PL330 can have an interrupt per context with up to 8 contexts and then 1 global interrupt. > > > Ideally I would say we don't know what the max here. We just have a platform > > implementing 2 interrupts now. Do we for with 2 for now and change it if some > > new users require more in the future ? > > > > By the spec seems to me that the maximum number of interrupts are equal to > the maximum possible channels (124), or one combined interrupt. > > But these in turn, as said, are capped by the AMBA_NR_IRQS and I have > only seen one system using 2. (for which I need this series to work) > > > I will leave that to the DT maintainers but 9 is simply random based on Linux > > code so I would rather choose some other random number with a better reasoning > > than 9 as AMBA code in the kernel is limiting it to 9. > > > > Agreed. Aiming to describe any possible hw in the DT, I would say 124 at > this point. (even though implausible not to use the combined interrupt > at that point...) Then use 124, but please describe how you get that in the description. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel