From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6DDDC77B6E for ; Wed, 12 Apr 2023 16:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=57C2Z+NhqsbYHKG3gppaw7rGXxDDWaOjNPIGZUaPsw8=; b=N7/ah1BE1XqpHL zK10rkklDoCKaXn3diTvzsGjGv76ZC55ljqDqchGy+d1XAgx9HbEmsWN08xPwe0QP/TrGvUwEzhLU DSwMG5KKWGsQ/YOI3YcgfSo52yYaYkRQY9gq9DJU8gnOK5sJauTLSHUFH3stvMEFHMSPRayI43RtO jYRccsJbfnWCBbtleZhjX2n8aF5aPraWkvEmicbxytPoOPYCrj8iU4GFct4SMMmOtoR4ltvI0JWiL 0U22tan1D+4OInCLBTm88BXfiQQvhMmu3QsP8jN2OPpkiwWJ9KQst3syWFM0c7pg20JVeLA4e1BIX LgcARu/gbdlgJX2rE31A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmdYs-003qpv-0a; Wed, 12 Apr 2023 16:43:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmdYo-003qob-0o for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 16:43:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 300A76339A; Wed, 12 Apr 2023 16:43:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EE23C4339B; Wed, 12 Apr 2023 16:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681317784; bh=tghXf6ZJNEtwzaF6Ct8z2O+2xY38x0zbM8ak45EK8/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JWsLHopw7Xr+qeJ+1ZM3O8jXOS/hjzlARh8LHzPdDwG+rLR9BrwuS67i5bgXb595o Zkm9JuIY3OViS+6mKEPuJkhVGdxZ5evNBBJHYkhONELH9iKazSefoTp8nAbuJNciW+ LxCnpQVHdhrATPb5DwgdpfMTPm6sHCqKoGeDhzgw= Date: Wed, 12 Apr 2023 18:43:01 +0200 From: Greg Kroah-Hartman To: John Moon Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Jordan Crouse , Trilok Soni , Satya Durga Srinivasu Prabhala , Elliot Berman , Guru Das Srinagesh Subject: Re: [PATCH v5 1/2] check-uapi: Introduce check-uapi.sh Message-ID: <2023041216-antitoxic-finch-dd14@gregkh> References: <20230407203456.27141-1-quic_johmoo@quicinc.com> <20230407203456.27141-2-quic_johmoo@quicinc.com> <2023041015-lunar-dandelion-1b4e@gregkh> <2023041136-donator-faceplate-5f91@gregkh> <2023041209-armed-overlaid-3d3d@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_094306_332170_A592D0EC X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 12, 2023 at 09:37:16AM -0700, John Moon wrote: > On 4/11/2023 11:14 PM, Greg Kroah-Hartman wrote: > > > Would you find the tool more useful if it simply filtered out all instances > > > where the size of the type did not change? This would filter out the > > > following which the tool currently flags: > > > > > > - enum expansions > > > - reserved field expansions > > > - expansions of a struct with a flex array at the end > > > - type changes > > > - re-ordering of existing members > > > - ...others? > > > > Obviously not, as some of those are real breakages, and some are not at > > all. > > > > Please understand what is an abi breakage. Adding new enums is not. > > Using a reserved field is not. Reording existing members IS. > > > > Yes, understood that method would miss certain classes of breakages. I was > suggesting it as a way to improve the signal-to-noise ratio of the tool > since we don't currently have an algorithm for determining breakages with > 100% accuracy. Why not? You know the different types of things here based on the differences between the dwarf data, and they fall into different categories, and those different categories mean different things. If you have questions as to which type of change is allowed and which is not, just ask us, the rules are not complex, nor impossible to describe, otherwise we wouldn't have a stable api at all, right? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel