From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1015C77B6E for ; Wed, 12 Apr 2023 17:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UhDUHt/hbcyyndib8neHRbxQ5aojidNIdOSrD7K2xJQ=; b=jGL9UdDy5xwuO9 32ICSbxzF/xEzmaplligNJpJD5MoF33RIvcwXAdOt/FBQL+gKwWdq2thIJ18viKfYvKFPaOxHrjCT jTSUJ9NxbSNLs1Hg66D2bMSI5KHHGcReLHGOYgGMamz+NXyKMRsDvZ4EVF+IBrPy2UEQ1R3i2WRhp U7IFBQNAmaZlI341REeaSly2jm6nplAD2JPVhGTDR0ThKbqBjaA8Ggk7i7IkX/o3NFsE8wBe/lKG6 X6TfPhvtJPCSADfEhxyZ3IwGWEOdLKDBAPQs+TvoYUKJhPHpc04dlLJ2XpL5gSwx2xm9oXg5AEfJm BwKUrg4I98mCr77448HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmdqP-003tum-1l; Wed, 12 Apr 2023 17:01:17 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmdqM-003ttm-1H for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 17:01:16 +0000 Received: by mail-pj1-x1032.google.com with SMTP id pc4-20020a17090b3b8400b0024676052044so12277126pjb.1 for ; Wed, 12 Apr 2023 10:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681318872; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pfUsMfkrejVXr5qJizoytRX5TpIEEU2cEnidL9qtDPI=; b=wYiC7zU09HzT5NwU6kVUFeXU5eGu/ear7WFELkED0oHU9+asu/YX8c1hxHuOwY/5Yt r/ADbqytIgvlGPpgtJdPDa68WehaZFMZimJjpGObFMQrIt+3x7S4yPNH4b9q/z54xyne o7mu2G/EZHJsTfs2zimGZccO1A31Kum5g18LB3viozu0AmZiNqI4VRaCqgG1eLeTyBt7 OQdC12oBUak1lSXsvUOZMIRIyzBoqIwNxqC+8+cYhNv2r6PzkvzHY2lhVy45vvjuZ/K+ g6b8t48tnMa4Gc0Ztj/TllWL+3PtpB53HArPqnMtE2BxLgD9jPBEvfWRkcHHS6qEVEYC 545w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681318872; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pfUsMfkrejVXr5qJizoytRX5TpIEEU2cEnidL9qtDPI=; b=Om14I7wHwQJY5c4rRa5y92BdmEDduzWhM4+OlDzcmK3XQPehC9ureVvah/4tsBy78o 5Q6fCbTZweCeOeujziihmXi0FVImAtPubjvAbdcHLDHiOl1NB0o8jYdEw6qEmI3Wu14l SmIJtuo1Y1WoxTYgQe1LyZBDyDR/YaJ4My+SsAXLSb2jv0QIYBDtmtmbxI+ZD8cb23bk 7Cu8TQ0FVHQNkBfk5+U9dtdtNwedA1jv+feHuUgVJkqhaw6UqB/m/bcRD6d0QUUJxjrZ ITJw22VqI9g6JQiBHpKc7PvIBpX+P+Y1/l5fRo8FGTCTkJ69fRY4PTegnYni/h6/L7gy U6rg== X-Gm-Message-State: AAQBX9dPrS8WAIZaSOqcRHwq2P/DimeME8Ovqf+1R3Vi1jYR4SIVAgGH N64dtys3eUAFPvb6jpnjrCqxzg== X-Google-Smtp-Source: AKy350bMg24lIg9DtnYv9P2T+iChkvOJJYeIXN0OleXUmzE+GwTjGgC/2dfRuQ61VwWLyEJ8A+ReCw== X-Received: by 2002:a17:902:e749:b0:1a6:61b5:9e78 with SMTP id p9-20020a170902e74900b001a661b59e78mr5729967plf.20.1681318872311; Wed, 12 Apr 2023 10:01:12 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:1cd7:1135:5e45:5f77]) by smtp.gmail.com with ESMTPSA id p6-20020a1709026b8600b001a04ff0e2eesm11749209plk.58.2023.04.12.10.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 10:01:11 -0700 (PDT) Date: Wed, 12 Apr 2023 11:01:09 -0600 From: Mathieu Poirier To: MD Danish Anwar Subject: Re: [PATCH v8 2/4] soc: ti: pruss: Add pruss_{request,release}_mem_region() API Message-ID: <20230412170109.GB86761@p14s> References: <20230412103012.1754161-1-danishanwar@ti.com> <20230412103012.1754161-3-danishanwar@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230412103012.1754161-3-danishanwar@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_100114_451619_2486DFA6 X-CRM114-Status: GOOD ( 32.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , srk@ti.com, linux-omap@vger.kernel.org, Vignesh Raghavendra , Tero Kristo , devicetree@vger.kernel.org, netdev@vger.kernel.org, Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrew F. Davis" , Roger Quadros , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 12, 2023 at 04:00:10PM +0530, MD Danish Anwar wrote: > From: "Andrew F. Davis" > > Add two new API - pruss_request_mem_region() & pruss_release_mem_region(), > to the PRUSS platform driver to allow client drivers to acquire and release > the common memory resources present within a PRU-ICSS subsystem. This > allows the client drivers to directly manipulate the respective memories, > as per their design contract with the associated firmware. > > Co-developed-by: Suman Anna > Signed-off-by: Suman Anna > Signed-off-by: Andrew F. Davis > Co-developed-by: Grzegorz Jaszczyk > Signed-off-by: Grzegorz Jaszczyk > Reviewed-by: Roger Quadros > Acked-by: Mathieu Poirier > Reviewed-by: Tony Lindgren > Reviewed-by: Simon Horman > Signed-off-by: MD Danish Anwar > --- > drivers/soc/ti/pruss.c | 77 ++++++++++++++++++++++++++++++++++++ > include/linux/pruss_driver.h | 22 +++++++++++ > 2 files changed, 99 insertions(+) > Acked-by: Mathieu Poirier > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index 3fac92df8790..8ada3758b31a 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -92,6 +92,82 @@ void pruss_put(struct pruss *pruss) > } > EXPORT_SYMBOL_GPL(pruss_put); > > +/** > + * pruss_request_mem_region() - request a memory resource > + * @pruss: the pruss instance > + * @mem_id: the memory resource id > + * @region: pointer to memory region structure to be filled in > + * > + * This function allows a client driver to request a memory resource, > + * and if successful, will let the client driver own the particular > + * memory region until released using the pruss_release_mem_region() > + * API. > + * > + * Return: 0 if requested memory region is available (in such case pointer to > + * memory region is returned via @region), an error otherwise > + */ > +int pruss_request_mem_region(struct pruss *pruss, enum pruss_mem mem_id, > + struct pruss_mem_region *region) > +{ > + if (!pruss || !region || mem_id >= PRUSS_MEM_MAX) > + return -EINVAL; > + > + mutex_lock(&pruss->lock); > + > + if (pruss->mem_in_use[mem_id]) { > + mutex_unlock(&pruss->lock); > + return -EBUSY; > + } > + > + *region = pruss->mem_regions[mem_id]; > + pruss->mem_in_use[mem_id] = region; > + > + mutex_unlock(&pruss->lock); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(pruss_request_mem_region); > + > +/** > + * pruss_release_mem_region() - release a memory resource > + * @pruss: the pruss instance > + * @region: the memory region to release > + * > + * This function is the complimentary function to > + * pruss_request_mem_region(), and allows the client drivers to > + * release back a memory resource. > + * > + * Return: 0 on success, an error code otherwise > + */ > +int pruss_release_mem_region(struct pruss *pruss, > + struct pruss_mem_region *region) > +{ > + int id; > + > + if (!pruss || !region) > + return -EINVAL; > + > + mutex_lock(&pruss->lock); > + > + /* find out the memory region being released */ > + for (id = 0; id < PRUSS_MEM_MAX; id++) { > + if (pruss->mem_in_use[id] == region) > + break; > + } > + > + if (id == PRUSS_MEM_MAX) { > + mutex_unlock(&pruss->lock); > + return -EINVAL; > + } > + > + pruss->mem_in_use[id] = NULL; > + > + mutex_unlock(&pruss->lock); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(pruss_release_mem_region); > + > static void pruss_of_free_clk_provider(void *data) > { > struct device_node *clk_mux_np = data; > @@ -294,6 +370,7 @@ static int pruss_probe(struct platform_device *pdev) > return -ENOMEM; > > pruss->dev = dev; > + mutex_init(&pruss->lock); > > child = of_get_child_by_name(np, "memories"); > if (!child) { > diff --git a/include/linux/pruss_driver.h b/include/linux/pruss_driver.h > index cb40c2b31045..c8f2e53b911b 100644 > --- a/include/linux/pruss_driver.h > +++ b/include/linux/pruss_driver.h > @@ -9,6 +9,7 @@ > #ifndef _PRUSS_DRIVER_H_ > #define _PRUSS_DRIVER_H_ > > +#include > #include > #include > #include > @@ -41,6 +42,8 @@ struct pruss_mem_region { > * @cfg_base: base iomap for CFG region > * @cfg_regmap: regmap for config region > * @mem_regions: data for each of the PRUSS memory regions > + * @mem_in_use: to indicate if memory resource is in use > + * @lock: mutex to serialize access to resources > * @core_clk_mux: clk handle for PRUSS CORE_CLK_MUX > * @iep_clk_mux: clk handle for PRUSS IEP_CLK_MUX > */ > @@ -49,6 +52,8 @@ struct pruss { > void __iomem *cfg_base; > struct regmap *cfg_regmap; > struct pruss_mem_region mem_regions[PRUSS_MEM_MAX]; > + struct pruss_mem_region *mem_in_use[PRUSS_MEM_MAX]; > + struct mutex lock; /* PRU resource lock */ > struct clk *core_clk_mux; > struct clk *iep_clk_mux; > }; > @@ -57,6 +62,10 @@ struct pruss { > > struct pruss *pruss_get(struct rproc *rproc); > void pruss_put(struct pruss *pruss); > +int pruss_request_mem_region(struct pruss *pruss, enum pruss_mem mem_id, > + struct pruss_mem_region *region); > +int pruss_release_mem_region(struct pruss *pruss, > + struct pruss_mem_region *region); > > #else > > @@ -67,6 +76,19 @@ static inline struct pruss *pruss_get(struct rproc *rproc) > > static inline void pruss_put(struct pruss *pruss) { } > > +static inline int pruss_request_mem_region(struct pruss *pruss, > + enum pruss_mem mem_id, > + struct pruss_mem_region *region) > +{ > + return -EOPNOTSUPP; > +} > + > +static inline int pruss_release_mem_region(struct pruss *pruss, > + struct pruss_mem_region *region) > +{ > + return -EOPNOTSUPP; > +} > + > #endif /* CONFIG_TI_PRUSS */ > > #endif /* _PRUSS_DRIVER_H_ */ > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel