Re: [PATCH v5 1/2] check-uapi: Introduce check-uapi.sh

John Moon
2023-04-13T17:34:55Z

On 4/13/2023 10:03 AM, Nicolas Schier wrote:
> On Mon, Apr 10, 2023 at 07:03:05PM +0900 Masahiro Yamada wrote:
>> CAVEAT
>> This tool runs 'git checkout' a couple of times internally.
>> If you interrupt it, your worktree might be messed up.
>
> John, did you consider using git export for obtaining a source tree that
> can be used for headers_install and the following comparison, instead of
> git stash+checkout? AFACS the script does not depend on any other git
> functionality than providing a specific version of the source tree. I am
> pretty sure that leaving the original working copy in its original state
> is supporting the script's popularity.
>
> Kind regards,
> Nicolas
>

I hadn't considered that. Great suggestion! I'll use this method in the
next rev. Thanks!