From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70601C77B6E for ; Fri, 14 Apr 2023 05:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lh7r62WvT1a9GP5YjOtceXGP0QVnPR2/sREaiXq4fU8=; b=Zh9ZbZ7KstGomV JSFZgSy0vMO6/LE5KuEIv5ZtPLP0/U/d9ohjP4GVhfH7J0ZLSi66D2AQ4DZvmliObPptQVD5QHjOK 4gVtGD2V1o1sTu25BMRM2s0zRTgeffgyT9lg2I9KZYOJsqP6AIPDdBt8mCiIDdV2N/16CTVnPgD90 YecVV+C3PDlGiplpUvs7mayU5OEzr/7XBjVP6d/oM5zheubcZUandPezEnSfMay1pinzDEAmluuoQ 7iE17FpL4Kv5KVWdz3g/nQer5/TdAafbZEyajefscnbPTvdBn4co0YWqLUI9kjGp59pVG13dmNEP9 abNQN0gPS1xNnhSlldVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnBYK-008Jay-2W; Fri, 14 Apr 2023 05:00:52 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnBYI-008JaR-0B for linux-arm-kernel@lists.infradead.org; Fri, 14 Apr 2023 05:00:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 195FE6437C; Fri, 14 Apr 2023 05:00:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2B95C433D2; Fri, 14 Apr 2023 05:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681448448; bh=CXO10PjY2/zG6b2bRTZgyHaMtJBiQFKnOvBLnoXwp3E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OtxFy53iprI5S3FaCLu1j1YLT0nHaMG8mq5nDd6a6av6Sq5yXeJBsgN9vYA7zZuaS yz6zr5CmXoNY59Km5LDmkHHECjVlUacCK6Dgj3qa6JRFVdxfxE5VxO2wXTa2DeNlH7 Kwwb9OQbNnLbyZCZWmLKQWtxGT9dpnk7C6zJRIFDvNPjsz1jLBj8bnOSyU2oHprzWj eCNTwFxRbqkUoT+zuIiCKFvBwbeOXI5p8cmM5ZR5jMD3rzKM7FCcw36Em1r2/uGoMX gGkEpypLzQaO0I4uAcgiNtuT7dqAKj1TxFOoJSMH6TZvIqwpXqTIm3a/vXCe3sUH5X ANM9oT9ucXZQA== Date: Thu, 13 Apr 2023 22:00:46 -0700 From: Jakub Kicinski To: Yan Wang Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Joakim Zhang , netdev@vger.kernel.org (open list:STMMAC ETHERNET DRIVER), linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net-next v3] net: stmmac:fix system hang when setting up tag_8021q VLAN for DSA ports Message-ID: <20230413220046.267fdc31@kernel.org> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_220050_152102_FFD8C48F X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 14 Apr 2023 11:07:10 +0800 Yan Wang wrote: > The system hang because of dsa_tag_8021q_port_setup()-> > stmmac_vlan_rx_add_vid(). > > I found in stmmac_drv_probe() that cailing pm_runtime_put() > disabled the clock. > > First, when the kernel is compiled with CONFIG_PM=y,The stmmac's > resume/suspend is active. > > Secondly,stmmac as DSA master,the dsa_tag_8021q_port_setup() function > will callback stmmac_vlan_rx_add_vid when DSA dirver starts. However, > The system is hanged for the stmmac_vlan_rx_add_vid() accesses its > registers after stmmac's clock is closed. > > I would suggest adding the pm_runtime_resume_and_get() to the > stmmac_vlan_rx_add_vid().This guarantees that resuming clock output > while in use. > > Fixes: b3dcb3127786 ("net: stmmac: correct clocks enabled in stmmac_vlan_rx_kill_vid()") > Signed-off-by: Yan Wang Happy to see you managed to work around the email server problems! Please make sure to read this doc before posting the next version: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel