From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99DD3C77B6E for ; Fri, 14 Apr 2023 08:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=wQ6cLSYgf+q90CTVvTILEmaVZQLMf81BQxY7GOiAnZ0=; b=YShJnQ+VznYChW f91Qaynj7+Sph/NZ5mZxZHeMmzOC8SAydk/SAEyPlj5SqSNnHP3YILx2opNpVbsDUe1JB/Ik5ZZLZ Z0SoMkD/JyEzvFySykl36T6BWvadDKJPjmvdCBcSRQWZB/tj6sg+2f4Ni8n/TNr0mpowtlygF10cg veClzLNyj2euwfehtuQg+xl/a78K0etjiLFVu4zXXjfJJUkfWfSNrGrizdCrvFHjSLzKwsRc4uurU rqHgSSY+igIT+MVGUvGIJPS4lrI1RHBTVA9HTR7LxwmxWaRPsxTJltPon2YvzKMCjcTYpv0V5Wuwx FKuikPP+ifnGMHS2BtpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnF5j-008mW9-1U; Fri, 14 Apr 2023 08:47:35 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnF5f-008mUz-2R for linux-arm-kernel@lists.infradead.org; Fri, 14 Apr 2023 08:47:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B911064599; Fri, 14 Apr 2023 08:47:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E51F5C433EF; Fri, 14 Apr 2023 08:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681462050; bh=xw5UWuO5hoCUdGrcFe+54+dstkTJi6Khjey9N+AhacI=; h=From:To:Cc:Subject:Date:From; b=BOHfu+Pfr4XbeColxttlDahpgJulwCsmF6zbAAZoR2tRpPDTHXQc+1U/3X2avhSGs VyC3Qp7r9O/y6U0xz67dWjDRGDbS5HYywzwuFbVEJsqdlANmFVRASbR7ga0qJ5NXJz HFfStk16/nZkUSu4soM4IgXcG3N/Xjuj4XyIneLP2dZ3R3fsSW6tzbbXmcsM8/DytZ 6rl9j5k/64FfayUr6KzB0QAZnktQzpIzI1c5VKVHdunlbDHG+fPqgUcI68SDbnc+un i1C4jR4SF8JqXt8ObvA2Rla4SMtuNAWuL0QwKtbogaN0L2sGGOQgwqpKCxilA9ijSa LRBM8CJIv6hCA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pnF5i-0008DN-LJ; Fri, 14 Apr 2023 10:47:35 +0200 From: Johan Hovold To: Mark Rutland , Lorenzo Pieralisi Cc: Ulf Hansson , Dmitry Baryshkov , Sudeep Holla , Daniel Lezcano , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH RESEND v2] firmware/psci: demote suspend-mode warning to info level Date: Fri, 14 Apr 2023 10:46:19 +0200 Message-Id: <20230414084619.31524-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_014731_855488_04588BB9 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this is now logged at warning level: psci: failed to set PC mode: -3 As there is nothing users can do about the firmware behaving this way, demote the warning to info level and clearly mark it as a firmware bug: psci: [Firmware Bug]: failed to set PC mode: -3 Reviewed-by: Ulf Hansson Acked-by: Mark Rutland Acked-by: Sudeep Holla Signed-off-by: Johan Hovold --- This one fell between the cracks so resending with tags added. Mark or Lorenzo, is this something you can pick up? Johan drivers/firmware/psci/psci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c index 29619f49873a..d9629ff87861 100644 --- a/drivers/firmware/psci/psci.c +++ b/drivers/firmware/psci/psci.c @@ -167,7 +167,8 @@ int psci_set_osi_mode(bool enable) err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); if (err < 0) - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); + pr_info(FW_BUG "failed to set %s mode: %d\n", + enable ? "OSI" : "PC", err); return psci_to_linux_errno(err); } -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel