From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 281CAC77B71 for ; Fri, 14 Apr 2023 18:27:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+SgquySUO7xlXrVLMhycS7rQASG+KqFATUbEdcvQuDc=; b=UeXSeWpuxQMj9U EIWmN0MNE3/5UMLLgSVOSdKpV3StR71aw4V6ca0su3vXNynhu7go9+uv8NozzBUbL3I3NRclvDQb8 IUYIHGCu3zPIgYCM+VvtSac/fvydDIBsi0DLP22jksrdMQ3+n35xU2B3gcj/1IDupaTIicOtGMzGI jAPYHNIKjOECcJWrSLFrpS1kPx/Or/SaNRDlqO3IpaItSxwnGIi9ZHTsEMCUHD6v/VD5rL2c0D8QA +sVqf6N9GWtvEByRFwrmzS9/hy+pltMfhU/xvLghO2M4/lwrY2dm65MjlvYGMbZdCJsg7JRnr7PNH CGZvoA++QUSbajHdpfxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnO8E-00AMDQ-2O; Fri, 14 Apr 2023 18:26:46 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnO8B-00AMD0-2N for linux-arm-kernel@lists.infradead.org; Fri, 14 Apr 2023 18:26:45 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33EIQdKk016155; Fri, 14 Apr 2023 13:26:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681496799; bh=f1rWEXtycthMgiKddjaoGBKDDMdqyZ3FLZjxYrgaVsw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=p/XuKZZ1/8xu/6kG1Qr1axqb5WCEaxO55Cn3hyZ6izlfzdV6oAzbfvN53IqupPLi7 2r0Vc1COKRhyrAQBdOHpCbA4TckKRyN4va0GUVgA14cfuBt12AhiZ5LJZ/KZgJragy 87d3OqseQHA+5UTd+uvBGmir8MBNWslpSpQdWXsY= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33EIQdaU005027 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Apr 2023 13:26:39 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 14 Apr 2023 13:26:38 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 14 Apr 2023 13:26:38 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33EIQc3r038020; Fri, 14 Apr 2023 13:26:38 -0500 Date: Fri, 14 Apr 2023 13:26:38 -0500 From: Nishanth Menon To: Udit Kumar CC: , , , , , , , , , , , , , J Keerthi Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin Message-ID: <20230414182638.watc555ihi2hgkuv@slinging> References: <20230414181434.2046049-1-u-kumar1@ti.com> <20230414181434.2046049-2-u-kumar1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230414181434.2046049-2-u-kumar1@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_112643_848301_99DB33BA X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23:44-20230414, Udit Kumar wrote: > Fixes: 9ae21ac445e9 ("arm64: dts: ti: k3-j7200: Fix wakeup pinmux range") In the wrong place. > > wkup_pmx splits into multiple regions. Like > > wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12) > wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15) > wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84) > wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100) > > With this split, pin offset needs to be adjusted to > match with new pmx for all pins above wkup_pmx0. > > Example a pin under wkup_pmx1 should start from 0 instead of > old offset(0x38 WKUP_PADCONFIG 14 offset) > > J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) : > https://www.ti.com/lit/ds/symlink/dra821u.pdf Drop the preceding whitespace. > > Signed-off-by: J Keerthi Spell check name please, I think he usually goes with: Signed-off-by: Keerthy If this patch is from Keerthy, the patch should have a "From:" > Signed-off-by: Udit Kumar > --- > .../dts/ti/k3-j7200-common-proc-board.dts | 28 +++++++++---------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > index 0d39d6b8cc0c..63633e4f6c59 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > @@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 { > &wkup_pmx2 { > mcu_cpsw_pins_default: mcu-cpsw-pins-default { > pinctrl-single,pins = < > - J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ > - J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ > - J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ > - J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ > - J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ > - J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ > - J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ > - J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ > - J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ > - J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ > - J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ > - J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ > + J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ > + J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ > + J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ > + J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ > + J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ > + J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ > + J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ > + J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ > + J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ > + J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ > + J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ > + J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ nice catch. > >; > }; > > mcu_mdio_pins_default: mcu-mdio1-pins-default { > pinctrl-single,pins = < > - J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ > - J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ > + J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ > + J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ > >; > }; > }; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel