From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DC7DC77B73 for ; Fri, 14 Apr 2023 18:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=72ESQDzZ1oc73FgXfVgx96Nd21C+ODGt7ZvQ8OO1Yoc=; b=XOg6hjaAOUyRWg gQgOz6nQoGoQp+Hs1tKYREvEQeZ/+m5+sH44aoMnLt7JkNeE9DMHJ2iWFGcsHdp6s98KaFsywgWPA B8j3TsUcDF4gpyTOgB5BWU6h8EhkASVCVdbvptOXEWhC1pywbsCyWSxEXWd6D8HvhPjQ0FJqrD9KT Qk+JPGjd7/WBVi1+r3Sb3yC3KrMbQAow1etKqK5rUDCQCJHvRH+vIPfBXu99QW5YPA5aTix9OL5rk XmvpRKoum/rLBUbXdH9k//oWxAAweTgntq7FExyHdf2lKgcHNVvTMiIb24b8Y+DBEMJER/iYMxvIX +mYWYBtfOQDM5hbfrAiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnOFE-00ANAT-03; Fri, 14 Apr 2023 18:34:00 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnOFC-00AN9o-0S for linux-arm-kernel@lists.infradead.org; Fri, 14 Apr 2023 18:33:59 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33EIXpFT122403; Fri, 14 Apr 2023 13:33:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681497231; bh=BD0CkY50IwBlYl+17boio/pHeWfDSupSaMF58t3hwwo=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=H1fsvPkxy5YRfVxd+Q33i/bxafE6+BNRgFmHiBboQzG/IMXs5pnDFNI30M7bBWSXt p80CffdXNeA8n+cbg48hkl8iKaEyUihI0/DDB49o2nHUS6p7c6YWBNpuVV1vN//CDH jzhEv/zRZybIxkHbOvTQTyZ4M1YKsdpbIenoReJM= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33EIXpDR009924 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Apr 2023 13:33:51 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 14 Apr 2023 13:33:50 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 14 Apr 2023 13:33:50 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33EIXo55061195; Fri, 14 Apr 2023 13:33:50 -0500 Date: Fri, 14 Apr 2023 13:33:50 -0500 From: Nishanth Menon To: Arnd Bergmann CC: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Santosh Shilimkar , Pengutronix Kernel Team , , , Tony Lindgren Subject: Re: [PATCH] soc: ti: smartreflex: Simplify getting the opam_sr pointer Message-ID: <20230414183350.mdvl2gcf6vaere2w@coleslaw> References: <20221012140032.113363-1-u.kleine-koenig@pengutronix.de> <20230412142539.brqexyi5kpac5ltr@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_113358_260017_3C5A33F8 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18:04-20230414, Arnd Bergmann wrote: > On Wed, Apr 12, 2023, at 16:25, Uwe Kleine-K=F6nig wrote: > > Hello, > > > > [Cc +=3D Tony Lindgren + Arnd Bergmann who did care about the last chan= ge > > to this driver] > > > > On Wed, Oct 12, 2022 at 04:00:32PM +0200, Uwe Kleine-K=F6nig wrote: > >> The probe function stores the sr_info pointer using > >> platform_set_drvdata(). Use the corresponding platform_get_drvdata() to > >> retrieve that pointer in the remove and shutdown functions. > >> = > >> This simplifies these functions and makes error handling unnecessary. > >> This is a good thing as at least for .remove() returning an error code > >> doesn't have the desired effect. > >> = > >> This is a preparation for making platform remove callbacks return void. > >> = > >> Signed-off-by: Uwe Kleine-K=F6nig > > > > This patch still applies to v6.3-rc1, but I didn't get any feedback > > since 6 months now. I need this change to eventually make > > platform_driver's remove callback return void. > = > Applied to the soc/drivers branch for 6.4 now. > = > Arnd Thanks Arnd, Tony. -- = Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5= 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel