From: Jisheng Zhang <jszhang@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
Vinod Koul <vkoul@kernel.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Logan Gunthorpe <logang@deltatee.com>,
Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: [PATCH v2 4/5] dmaengine: hidma: Don't set chancnt
Date: Sat, 15 Apr 2023 17:55:16 +0800 [thread overview]
Message-ID: <20230415095517.2763-5-jszhang@kernel.org> (raw)
In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org>
The dma framework will calculate the dma channels chancnt, setting it
ourself is wrong.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/dma/qcom/hidma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index 04d1c33afc12..344525c3a32f 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -214,7 +214,6 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig)
spin_lock_init(&mchan->lock);
list_add_tail(&mchan->chan.device_node, &ddev->channels);
- dmadev->ddev.chancnt++;
return 0;
}
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-15 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 9:55 [PATCH v2 0/5] dma: don't set chancnt Jisheng Zhang
2023-04-15 9:55 ` [PATCH v2 1/5] dmaengine: dw-axi-dmac: Don't " Jisheng Zhang
2023-04-15 9:55 ` [PATCH v2 2/5] dmaengine: axi-dmac: " Jisheng Zhang
2023-04-15 9:55 ` [PATCH v2 3/5] dmaengine: plx_dma: " Jisheng Zhang
2023-04-17 16:50 ` Logan Gunthorpe
2023-04-15 9:55 ` Jisheng Zhang [this message]
2023-04-15 9:55 ` [PATCH v2 5/5] dmaengine: sprd: " Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230415095517.2763-5-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=okaya@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=vkoul@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).