From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB012C77B61 for ; Sun, 16 Apr 2023 12:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MKw+6JO0CmHpxxGYWA8FXXZOXrGxTPk/MSjwIryeBqk=; b=IBLHiTk8IFaeRh n7D8HrzVZdQiSSVSVcQiLfXaF60EYx/VOHVlOljZTieA7+/22EB7yPoIRiqvPOzheI0wiH+AHtkfa RENxD/kNzU0YBFIBMcdT4njJ5/9nAt7dASgnRa1QLAMcmJc31I7RkLws8UgRiHdjylilEewu113lB CrTP8kXy4RBY7R4pGgio+ltQcinEiILc0h1NvZ1tn95ypMSow2OUwcX87Qopd1J3etz3TZn+IOHGM 1fwdTigF8FgmdLMAVx9OkDhwMsQogQof1StYimJUNyoIflZoT/znhDyGd7JsGcQkt5ntJtacUZqLS aeScehjc71UjIgmPmdsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1po1VG-00DnU2-1U; Sun, 16 Apr 2023 12:29:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1po1VC-00DnSv-2w for linux-arm-kernel@lists.infradead.org; Sun, 16 Apr 2023 12:29:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78BFD60FCA; Sun, 16 Apr 2023 12:29:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9049DC433EF; Sun, 16 Apr 2023 12:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681648145; bh=5PL0hkKXz5ojQm8kj6YRRLyZRbwnEHLHp0vxMogvW30=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DiF+ue7KxEntambN+egSr8hBnXyi2SApEZa7wjWOUtCyfAy7+91zOLnnNdmMNo/Rt qN5aVsrGXDceTxS7F256H2nFCum+rocx4KMfAalo46QKMomhMKO/Ah726FE6oeDgNL PefGfZDeJV++dA4nmUt0p48JkXvbPOZkC5rV3JYO5H4lscUOQVOgeOkFBN8Z0c4umT On8O6pydCQ0y9fmzlWtnGMCiIdRLGXBU7+paPv9mG3o9tPIcFsV3cY7Q8fgXZilZ99 Uvblx9/Hj3dIsrueAIFpqt5LNGSReone9cD1sKTN1w/0eyD64DVW3qAJAYeSfTlQOI IGH+F7J/UiDrQ== Date: Sun, 16 Apr 2023 13:29:06 +0100 From: Jonathan Cameron To: Jiakai Luo Cc: Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Ksenija Stanojevic , Lee Jones , Marek Vasut , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: adc: mxs-lradc: fix the order of two cleanup operations Message-ID: <20230416132906.4ec56e47@jic23-huawei> In-Reply-To: <20230416072157.57388-1-jkluo@hust.edu.cn> References: <20230416072157.57388-1-jkluo@hust.edu.cn> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230416_052907_025536_FCD4402D X-CRM114-Status: GOOD ( 22.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 16 Apr 2023 00:21:57 -0700 Jiakai Luo wrote: > Smatch reports: > drivers/iio/adc/mxs-lradc-adc.c:766 mxs_lradc_adc_probe() warn: > missing unwind goto? > > the order of three init operation: > 1.mxs_lradc_adc_trigger_init > 2.iio_triggered_buffer_setup > 3.mxs_lradc_adc_hw_init > > thus, the order of three cleanup operation should be: > 1.mxs_lradc_adc_hw_stop > 2.iio_triggered_buffer_cleanup > 3.mxs_lradc_adc_trigger_remove > > we exchange the order of two cleanup operations, > introducing the following differences: > 1.if mxs_lradc_adc_trigger_init fails, returns directly; > 2.if trigger_init succeeds but iio_triggered_buffer_setup fails, > goto err_trig and remove the trigger. > > v1->v2: exchange the order of mxs_lradc_adc_trigger_remove() > and iio_triggered_buffer_cleanup() in error handling labels Move your change log to after the --- marking below. We don't want to retain that level of detail in the commit logs in the git tree. Thanks, Jonathan > > Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver") > Signed-off-by: Jiakai Luo > Reviewed-by: Dongliang Mu > --- > drivers/iio/adc/mxs-lradc-adc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c > index bca79a93cbe4..d32e9b1d03ce 100644 > --- a/drivers/iio/adc/mxs-lradc-adc.c > +++ b/drivers/iio/adc/mxs-lradc-adc.c > @@ -757,13 +757,13 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev) > > ret = mxs_lradc_adc_trigger_init(iio); > if (ret) > - goto err_trig; > + return ret; > > ret = iio_triggered_buffer_setup(iio, &iio_pollfunc_store_time, > &mxs_lradc_adc_trigger_handler, > &mxs_lradc_adc_buffer_ops); > if (ret) > - return ret; > + goto err_trig; > > adc->vref_mv = mxs_lradc_adc_vref_mv[lradc->soc]; > > @@ -801,9 +801,9 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev) > > err_dev: > mxs_lradc_adc_hw_stop(adc); > - mxs_lradc_adc_trigger_remove(iio); > -err_trig: > iio_triggered_buffer_cleanup(iio); > +err_trig: > + mxs_lradc_adc_trigger_remove(iio); > return ret; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel