Re: [PATCH 4/4] riscv: Enable perf counters user access only through perf

kernel test robot
2023-04-14T02:11:23Z

Hi Alexandre,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on acme/perf/core tip/master tip/auto-latest linus/master v6.3-rc6]
[cannot apply to next-20230413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Alexandre-Ghiti/perf-Fix-wrong-comment-about-default-event_idx/20230414-002232
patch link: https://lore.kernel.org/r/20230413161725.195417-5-alexghiti%40rivosinc.com
patch subject: [PATCH 4/4] riscv: Enable perf counters user access only through perf
config: riscv-randconfig-r036-20230412 (https://download.01.org/0day-ci/archive/20230414/202304140904.9oAVhFHu-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 9638da200e00bd069e6dd63604e14cbafede9324)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/8ca9b21cbf2c0b91ee35356c01aef9da7d874e55
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Alexandre-Ghiti/perf-Fix-wrong-comment-about-default-event_idx/20230414-002232
git checkout 8ca9b21cbf2c0b91ee35356c01aef9da7d874e55
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304140904.9oAVhFHu-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/riscv/kernel/perf_event.c:8:28: error: call to undeclared function 'to_riscv_pmu'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
struct riscv_pmu *rvpmu = to_riscv_pmu(event->pmu);
^
>> arch/riscv/kernel/perf_event.c:8:20: error: incompatible integer to pointer conversion initializing 'struct riscv_pmu *' with an expression of type 'int' [-Wint-conversion]
struct riscv_pmu *rvpmu = to_riscv_pmu(event->pmu);
^ ~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/riscv/kernel/perf_event.c:24:27: error: incomplete definition of type 'struct riscv_pmu'
userpg->pmc_width = rvpmu->ctr_get_width(event->hw.idx) + 1;
~~~~~^
arch/riscv/kernel/perf_event.c:8:9: note: forward declaration of 'struct riscv_pmu'
struct riscv_pmu *rvpmu = to_riscv_pmu(event->pmu);
^
3 errors generated.

vim +/to_riscv_pmu +8 arch/riscv/kernel/perf_event.c

4
5 void arch_perf_update_userpage(struct perf_event *event,
6 struct perf_event_mmap_page *userpg, u64 now)
7 {
> 8 struct riscv_pmu *rvpmu = to_riscv_pmu(event->pmu);
9 struct clock_read_data *rd;
10 unsigned int seq;
11 u64 ns;
12
13 userpg->cap_user_time = 0;
14 userpg->cap_user_time_zero = 0;
15 userpg->cap_user_time_short = 0;
16 userpg->cap_user_rdpmc =
17 !!(event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT);
18
19 /*
20 * The counters are 64-bit but the priv spec doesn't mandate all the
21 * bits to be implemented: that's why, counter width can vary based on
22 * the cpu vendor.
23 */
> 24 userpg->pmc_width = rvpmu->ctr_get_width(event->hw.idx) + 1;

--
0-DAY CI Kernel Test Service