From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1015AC77B71 for ; Tue, 18 Apr 2023 09:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KEyYvzIJe6T5xy+/FbV+6C86bCZRb0MVHPsefNCC91E=; b=4NJgPX/sEURUJm EmWIWT+BEcTCVrHN9slYxPv1T8ecsJ1zAn+jgm+YZrnXA1PR9+d1cyxY9eW+EIZkCZuu5TAZZse2N fo1gzuzIuOV9gwaJ+HBA6HlbMau38kHxgapppCCu4YfcpwB8VkfNFxWyBG8GovaN0ZrU7GNmL+SGM 7IspGHh7nlxG3omaaDaq0knZLtcbNJJT6S+5h2TePT0qQPpxEXCSe44AroyULJN+MLU7Kc2hqKeM2 cV3ZYatfnQFoqUjaA9ojkS0FR/mPUkHkbRpdDtLw4XDGM79FjBTOeCsOB5kf7gE+a4mgO5z1hH/JN ZRC/b1IDQZ8XF7sCjLiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pohjE-001UfC-0g; Tue, 18 Apr 2023 09:34:24 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pohjC-001UeT-0O for linux-arm-kernel@lists.infradead.org; Tue, 18 Apr 2023 09:34:23 +0000 Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCA06127D; Tue, 18 Apr 2023 11:34:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1681810454; bh=DcyR3TugJBSvWYo6H5+J4MYHNLWI7TCjYdL4toCds1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S2AN13RC2z+Raz07Laph9QkNIAU2LbsJO1Im+Sd1kBWBiL9/Yhi/68vdQdCy3C+p5 zSsRSEe+FYXLFnPQ8eMsf2LS5pnY+HNWl0p8BzhAfnbQqBt+aUlxPIaKB1VRN60o6l 84iTGvvFw05+IARu1BpGbQuoFgzzAjUpjLRTjOvU= Date: Tue, 18 Apr 2023 12:34:31 +0300 From: Laurent Pinchart To: Alexander Stein Cc: Rui Miguel Silva , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] media: imx: imx7-media-csi: Remove interlave fields Message-ID: <20230418093431.GA11510@pendragon.ideasonboard.com> References: <20230418071439.197735-1-alexander.stein@ew.tq-group.com> <20230418071439.197735-3-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230418071439.197735-3-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_023422_304305_57502F6B X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Thank you for the patch. On Tue, Apr 18, 2023 at 09:14:38AM +0200, Alexander Stein wrote: > Interlaced mode is currently not supported, so disable fields in try_fmt. > > Signed-off-by: Alexander Stein > --- > drivers/media/platform/nxp/imx7-media-csi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c > index bd649fd9166fd..1508f6ba20e91 100644 > --- a/drivers/media/platform/nxp/imx7-media-csi.c > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > @@ -1178,6 +1178,7 @@ __imx7_csi_video_try_fmt(struct v4l2_pix_format *pixfmt, You should also drop the following code in the same function: /* Allow IDMAC interweave but enforce field order from source. */ if (V4L2_FIELD_IS_INTERLACED(pixfmt->field)) { switch (pixfmt->field) { case V4L2_FIELD_SEQ_TB: pixfmt->field = V4L2_FIELD_INTERLACED_TB; break; case V4L2_FIELD_SEQ_BT: pixfmt->field = V4L2_FIELD_INTERLACED_BT; break; default: break; } } > stride = round_up((pixfmt->width * cc->bpp) / 8, 8); > pixfmt->bytesperline = stride; > pixfmt->sizeimage = stride * pixfmt->height; > + pixfmt->field = V4L2_FIELD_NONE; > > if (compose) { > compose->width = pixfmt->width; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel