From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1D12C77B75 for ; Tue, 18 Apr 2023 18:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qvvy8wPDoklx/3xf6FzTlq0poQ7oXVY6cy77hOkVC3Y=; b=gxXdGm2WReiZXK z2pDaAcIRfjgR8TRKZk+8V2EptCjecTsqXnGX4An76TRv5WFPHtKyhXFekOVP8fAx4cYWFZwCQnHV ohuYQIFoUhjFZXpk5p/sH8bEB87mlXgX2hXYduCIQJFxlVj5OR+7LEd3SQzt5KQF1ILnfZc1dwHWo gOG5I0hNwnqtmN+3gbwnikN9v64y7VnrQcaNt6Z8yjnt3cX2ICLI4BHj59iNMoL4LBmQPEhKwb3yk MU+tg/5tw+e856+EYxwJrPt35w1sQf9QR9MiapsWwtj0O0UaojSQRTSZVxmLbaG1tGwkcJU5+f10/ 5ZPAM5S4HIngGGdtrkOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poqK5-0036mk-11; Tue, 18 Apr 2023 18:45:01 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poqK2-0036lk-2s for linux-arm-kernel@lists.infradead.org; Tue, 18 Apr 2023 18:45:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68E7D61226; Tue, 18 Apr 2023 18:44:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EB90C4339B; Tue, 18 Apr 2023 18:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681843497; bh=VTJaQ+xSNEjvC73iIJnvJAGbN1KdAIOE9HBhu+8VB7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iwinOfDo013AYR1eTqfKRbf8QgIMvXjWV1uDAsJK/6//hApF3lFOjUP0j95Ovb+k+ KIYph9qZmZLqfiV4GQgCD9C1MWQz7KVPVpt8bxaXsPkMZXFnAQI/a6tKpZCEvjlKKd t5V0J/ED7u16H24IxG7q7+Nd0tOlG1+4kbLipuquPawMQqDAVmB1T3Ty7WYRwHARkG 7Gn39ingpfNH3D5FvVevL23BxGJKeJcOhJxGEoKz9cFwYHcdtLKFyHQL0gQ1Rk8W9P CjJEqODbuj2wUXGPUhkmqkU724mW8kkrL7vBPDFDc7PzNe7yNRlR/MAI76ljvJDr2I Di1fvwMgo9NnA== Date: Tue, 18 Apr 2023 11:44:55 -0700 From: Nathan Chancellor To: Simon Horman Cc: Nishanth Menon , Santosh Shilimkar , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH] soc: ti: pruss: Avoid cast to incompatible function type Message-ID: <20230418184455.GC2635379@dev-arch.thelio-3990X> References: <20230418-pruss-clk-cb-v1-1-549a7e7febe4@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230418-pruss-clk-cb-v1-1-549a7e7febe4@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_114458_967582_801E8FD1 X-CRM114-Status: GOOD ( 20.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 18, 2023 at 01:41:48PM +0200, Simon Horman wrote: > Rather than casting clk_unregister_mux to an incompatible function > type provide a trivial wrapper with the correct signature for the > use-case. > > Reported by clang-16 with W=1: > > drivers/soc/ti/pruss.c:158:38: error: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict] > ret = devm_add_action_or_reset(dev, (void(*)(void *))clk_unregister_mux, > > No functional change intended. > Compile tested only. > > Signed-off-by: Simon Horman Reviewed-by: Nathan Chancellor > --- > drivers/soc/ti/pruss.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index 6882c86b3ce5..e68441bd7b30 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -38,6 +38,11 @@ static void pruss_of_free_clk_provider(void *data) > of_node_put(clk_mux_np); > } > > +static void pruss_clk_unregister_mux(void *data) > +{ > + clk_unregister_mux(data); > +} > + > static int pruss_clk_mux_setup(struct pruss *pruss, struct clk *clk_mux, > char *mux_name, struct device_node *clks_np) > { > @@ -93,8 +98,7 @@ static int pruss_clk_mux_setup(struct pruss *pruss, struct clk *clk_mux, > goto put_clk_mux_np; > } > > - ret = devm_add_action_or_reset(dev, (void(*)(void *))clk_unregister_mux, > - clk_mux); > + ret = devm_add_action_or_reset(dev, pruss_clk_unregister_mux, clk_mux); > if (ret) { > dev_err(dev, "failed to add clkmux unregister action %d", ret); > goto put_clk_mux_np; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel