From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B554C77B75 for ; Tue, 18 Apr 2023 22:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aL4W+JSWzvFDBbYYn7sMA/3I3oxgwF2TFPFFZJMxQ7o=; b=vuuvSgLN2WZUnn PFMw/B9knp4tMpTjnTf/DKkM1ZtFmgg8f/L+voIrk1R2l5JYZYgtdp0KYUYyRI7GBPOXFBA7kHbEa qYCIToOCyATjhRyZRUDCIOJuNXmlIStQfjZymJxJ3BflGnyrroQiM2ikuy/C+ZRWh0PgX/5ScOLnk 1KBnE9GZP9SaKBcV1sjgvNFPQNjCZ9Wr4ddSPkEEdl9rYpUqD2+F+LZhIbiXHGJbEoQnLxuAiQUZq htaSDd4V+mn5ssUTLr0PVM8tzMPDHueceG3P4HXHLMlE1Vow04yOYtEOSQZ+ij7aLnfq60VXoplcr +fkNzmr/L8fC++1Odm0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pou1K-003Vb3-1z; Tue, 18 Apr 2023 22:41:54 +0000 Received: from mail-oo1-f51.google.com ([209.85.161.51]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pou1H-003Vai-1z for linux-arm-kernel@lists.infradead.org; Tue, 18 Apr 2023 22:41:53 +0000 Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-541b60e2647so679351eaf.1 for ; Tue, 18 Apr 2023 15:41:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681857709; x=1684449709; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4erP0VsSx34YeXcErgipr+nd4eR3XtxADF/qUHIhYAg=; b=Cayuve0jKnWjfRUc4wRtq8o32VkFi2YArRkPnhu4rvKkgTZyQ+CgQdPtACbFCPXqYE AwWATxhf6w3Orhnj7r6ktOF5PYQ0slbSvObDEEeOe087yYdEViSr31PM9Z6+Bhbo0Otv czdXgv3kxzx2OS8Im+2465h9AT2DDsLls3TyPpVj8+XYlcHHm0e/U22DxALRJReLf6Ns JQnDTSGOw3aYQYZs/oTlkzozHxk6uG10wkEDj8CWW/FVAH9ARWUHSYoBHiOR0IzYihZi 9vmFJg6xPFDIq3olcqKQjgeNKSPiXSYlgwfsr8nmLmDYsdOqY2YNaAj4MKxVApNXLg54 1o7g== X-Gm-Message-State: AAQBX9cLLfDd8V03AzKVPvIHSgAxhDMSBCjSGQRNVAMCcVxLIUrygNOJ dVNGRi5alDfewg8Sz4a0TA== X-Google-Smtp-Source: AKy350ZNnMxDWnMjDmUodqaqxOtd7hdDsrTfnCpoppZ4zWEa7VXLHMnr2biukzmVvJcCex7AdC31zw== X-Received: by 2002:a05:6808:1402:b0:38d:ee6e:235f with SMTP id w2-20020a056808140200b0038dee6e235fmr2430172oiv.47.1681857707478; Tue, 18 Apr 2023 15:41:47 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i11-20020aca3b0b000000b0038c235e24fesm2571828oia.48.2023.04.18.15.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 15:41:47 -0700 (PDT) Received: (nullmailer pid 2456811 invoked by uid 1000); Tue, 18 Apr 2023 22:41:46 -0000 Date: Tue, 18 Apr 2023 17:41:46 -0500 From: Rob Herring To: Linus Walleij Cc: Vinod Koul , Krzysztof Kozlowski , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] dt-bindings: dma: dma40: Prefer to pass sram through phandle Message-ID: <20230418224146.GA2453289-robh@kernel.org> References: <20230417-ux500-dma40-cleanup-v1-0-b26324956e47@linaro.org> <20230417-ux500-dma40-cleanup-v1-1-b26324956e47@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230417-ux500-dma40-cleanup-v1-1-b26324956e47@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_154151_653574_274F621C X-CRM114-Status: GOOD ( 20.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 17, 2023 at 09:55:46AM +0200, Linus Walleij wrote: > Extend the DMA40 bindings so that we can pass two SRAM > segments as phandles instead of directly referring to the > memory address in the second reg cell. This enables more > granular control over the SRAM, and adds the optiona LCLA > SRAM segment as well. > > Deprecate the old way of passing LCPA as a second reg cell, > make sram compulsory. > > Signed-off-by: Linus Walleij > --- > .../devicetree/bindings/dma/stericsson,dma40.yaml | 35 +++++++++++++++++----- > 1 file changed, 27 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml > index 64845347f44d..4fe0df937171 100644 > --- a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml > +++ b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml > @@ -112,14 +112,23 @@ properties: > - const: stericsson,dma40 > > reg: > - items: > - - description: DMA40 memory base > - - description: LCPA memory base > + oneOf: > + - items: > + - description: DMA40 memory base > + - items: > + - description: DMA40 memory base > + - description: LCPA memory base, deprecated, use eSRAM pool instead > + deprecated: true > + > > reg-names: > - items: > - - const: base > - - const: lcpa > + oneOf: > + - items: > + - const: base > + - items: > + - const: base > + - const: lcpa > + deprecated: true > > interrupts: > maxItems: 1 > @@ -127,6 +136,14 @@ properties: > clocks: > maxItems: 1 > > + sram: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' Drop quotes. > + items: > + maxItems: 2 phandle-array really means phandle+args array. So the inner size is 1 plus number of arg cells. Since you have no arg cells, that would be: maxItems: 2 items: maxItems: 1 > + description: > + List of phandles for the SRAM used by the DMA40 block, the first > + phandle is the LCPA memory, the second is the LCLA memory. > + > memcpy-channels: > $ref: /schemas/types.yaml#/definitions/uint32-array > description: Array of u32 elements indicating which channels on the DMA > @@ -138,6 +155,7 @@ required: > - reg > - interrupts > - clocks > + - sram > - memcpy-channels > > additionalProperties: false > @@ -149,8 +167,9 @@ examples: > #include > dma-controller@801c0000 { > compatible = "stericsson,db8500-dma40", "stericsson,dma40"; > - reg = <0x801c0000 0x1000>, <0x40010000 0x800>; > - reg-names = "base", "lcpa"; > + reg = <0x801c0000 0x1000>; > + reg-names = "base"; > + sram = <&lcpa>, <&lcla>; > interrupts = ; > #dma-cells = <3>; > memcpy-channels = <56 57 58 59 60>; > > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel