From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DD8EC6FD18 for ; Tue, 25 Apr 2023 18:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J9JFaz+mRcdvQbPrXDs/pr4Owa/JzdXesDZLU4xi8BY=; b=PV2qXIUe8Szlfy Ndz88ZeImyayBArQHW/56g0tGlU4Uj3z5Ga8sFAdgmKdTesp00MJpKp/6wAUO6Jl35dFUPNVpVLsi PKTbzRpcQQU7Kmdd40rAY5w6xHDVIg1hxiOfHV5O9pzMaO/4zikO9H1t0TA7BTUmGDIH+QEWgsQex gfMIbKXxIGmirtEUMN6PRu0iJhbyiCuTiDS3Kb6ThfLg91aVAlgODYHalpiSX64pblfDr9uSX59Ig DN8GkBic0vpv+ShgGK9fl/mz5opVsjb6+JAMrV0oC41ZT5JgCiVWFyTBak+DOk2wwiMdBTrdhVquI UVkV/kK/T0DyG+Z/RCvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prNgt-001yOH-2J; Tue, 25 Apr 2023 18:47:03 +0000 Received: from mail-oa1-f49.google.com ([209.85.160.49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prNgq-001yMl-18 for linux-arm-kernel@lists.infradead.org; Tue, 25 Apr 2023 18:47:01 +0000 Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-18ecdb1f2aaso6556582fac.1 for ; Tue, 25 Apr 2023 11:46:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682448416; x=1685040416; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KUQiQ/cycrAa4n9iZRt3Zgr4LfG6yW1fRE0hcsRmUfQ=; b=iiBKsw/KqhVlfTBJ0qknYSDWT4BYPmbm0Zuk9BI7irDH7UBam4i7AWSdPhvN/mjj+Z EB4zOxZ/5VXoVCLhOHCt2Wl/PrNoXS39N5SkhKK9IjKX68xUr87nD7HTjym0ulM+fPb4 yPe4HdDGnWb9SeKnlS5r6FXiBOunuspb/WN0TqZQQuE6NYRUu/d22i0I7L3YwblCNhYf tYlEl/7RnDAXAWR3Xbv52jk/ekKIruWhj3hl2MUjPvTaq+IbilyHAJHlWPDODVLMarvI WMN9vDVJ7F5UvjEoJQdN8tkDvwYPzyN51ipOGgZbUh0ruPXbw9bTsSu8nE7MUH2jhwqu 9OqA== X-Gm-Message-State: AAQBX9d4FJINL7yWKnCVAx8U0carzoi9wlsgdsCgap9v3lM7dQ9eYL+C 5daTbNezkSS509PUIPZBvA== X-Google-Smtp-Source: AKy350a9gR40wr81MPVCWEPH2D/7sm+9b9p11s31OwD5EHu62Pt7kbhb85SbKjjVrnX0z5MDz6Fg4A== X-Received: by 2002:a05:6830:130e:b0:6a1:2c80:5a3f with SMTP id p14-20020a056830130e00b006a12c805a3fmr9233595otq.19.1682448416562; Tue, 25 Apr 2023 11:46:56 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id p26-20020a9d695a000000b006a13dd5c8a2sm5991901oto.5.2023.04.25.11.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 11:46:56 -0700 (PDT) Received: (nullmailer pid 2070614 invoked by uid 1000); Tue, 25 Apr 2023 18:46:54 -0000 Date: Tue, 25 Apr 2023 13:46:54 -0500 From: Rob Herring To: Hao Zhang Cc: Suzuki K Poulose , Mike Leach , Leo Yan , Alexander Shishkin , Mathieu Poirier , Konrad Dybcio , Krzysztof Kozlowski , Andy Gross , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jonathan Corbet , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Jinlong Mao , Yuanfang Zhang , Tao Zhang , Trilok Soni , linux-arm-msm@vger.kernel.org, Bjorn Andersson , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 2/3] dt-bindings: arm: Add Coresight Dummy Trace Message-ID: <20230425184654.GA2063541-robh@kernel.org> References: <20230422073714.38844-1-quic_hazha@quicinc.com> <20230422073714.38844-3-quic_hazha@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230422073714.38844-3-quic_hazha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230425_114700_392394_EEA24B78 X-CRM114-Status: GOOD ( 27.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 22, 2023 at 03:37:13PM +0800, Hao Zhang wrote: > Add new coresight-dummy.yaml file describing the bindings required > to define coresight dummy trace in the device trees. > > Signed-off-by: Hao Zhang > --- > .../bindings/arm/arm,coresight-dummy.yaml | 101 ++++++++++++++++++ > 1 file changed, 101 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dummy.yaml > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy.yaml > new file mode 100644 > index 000000000000..48d864aefaaa > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy.yaml > @@ -0,0 +1,101 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/arm,coresight-dummy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ARM Coresight Dummy component > + > +description: | > + Coresight Dummy Trace Module is for the specific devices that kernel > + don't have permission to access or configure, e.g., CoreSight TPDMs > + on Qualcomm platforms. So there need driver to register dummy devices > + as Coresight devices. It may also be used to define components that > + may not have any programming interfaces (e.g, static links), so that > + paths can be established in the driver. Provide Coresight API for > + dummy device operations, such as enabling and disabling dummy devices. > + Build the Coresight path for dummy sink or dummy source for debugging. > + > + The primary use case of the coresight dummy is to build path in kernel > + side for dummy sink and dummy source. I could imagine the OS wanting to know more information than just 'dummy'. Is data from an unknown source useful? Likewise, don't you want to know where you are sending data too? > + > +maintainers: > + - Mao Jinlong > + - Tao Zhang > + - Hao Zhang > + > +properties: > + compatible: > + oneOf: > + - enum: Don't need oneOf as there is only one entry. > + - arm,coresight-dummy-sink > + - arm,coresight-dummy-source > + > + out-ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port: > + description: Output connection from the source to Coresight > + Trace bus. > + $ref: /schemas/graph.yaml#/properties/port > + > + in-ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port: > + description: Input connection from the Coresight Trace bus to > + dummy sink, such as Embedded USB debugger(EUD). > + $ref: /schemas/graph.yaml#/properties/port > + > +required: > + - compatible > + > +if: > + # If the compatible contains the below value > + properties: > + compatible: > + contains: > + const: arm,coresight-dummy-sink > + > +then: > + required: > + - in-ports > + > +else: > + required: > + - out-ports This still allows the nodes when they don't make sense. I think this needs to be 2 schema files. The only common part is 'compatible' and that's not even shared. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel