From: Philipp Zabel <p.zabel@pengutronix.de>
To: Daniel Golle <daniel@makrotopia.org>
Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Arınç Ünal" <arinc.unal@arinc9.com>,
"Sam Shih" <Sam.Shih@mediatek.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"John Crispin" <john@phrozen.org>, "Felix Fietkau" <nbd@nbd.name>
Subject: Re: [PATCH net-next v2 13/14] net: dsa: mt7530: introduce driver for MT7988 built-in switch
Date: Wed, 26 Apr 2023 09:44:53 +0200 [thread overview]
Message-ID: <20230426074453.GD4724@pengutronix.de> (raw)
In-Reply-To: <ZEf7uMIydCzxS437@makrotopia.org>
Hi Daniel,
On Tue, Apr 25, 2023 at 05:11:36PM +0100, Daniel Golle wrote:
> On Tue, Apr 25, 2023 at 05:51:37PM +0200, Philipp Zabel wrote:
[...]
> > Please use devm_reset_control_get_exclusive() directly.
> >
> > > + if (IS_ERR(priv->rstc)) {
> > > + dev_err(&pdev->dev, "Couldn't get our reset line\n");
> > > + return PTR_ERR(priv->rstc);
> >
> > Not sure if this can actually happen, but there is no need to warn on
> > -EPROBE_DEFER. You could use return dev_err_probe(...) here.
>
> Thank you for your comments. The series has already been picked to
> net-next. Unless you want to send the suggested changes yourself, I will
> prepare another series with your suggestions, and also apply them to
> mt7530-mdio.c.
That would be great, thank you.
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-26 7:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 1:16 [PATCH net-next v2 00/14] net: dsa: add support for MT7988 Daniel Golle
2023-04-03 1:17 ` [PATCH net-next v2 01/14] net: dsa: mt7530: make some noise if register read fails Daniel Golle
2023-04-03 1:17 ` [PATCH net-next v2 02/14] net: dsa: mt7530: refactor SGMII PCS creation Daniel Golle
2023-04-03 1:17 ` [PATCH net-next v2 03/14] net: dsa: mt7530: use unlocked regmap accessors Daniel Golle
2023-04-03 1:17 ` [PATCH net-next v2 04/14] net: dsa: mt7530: use regmap to access switch register space Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 05/14] net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 06/14] net: dsa: mt7530: introduce mutex helpers Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 07/14] net: dsa: mt7530: move p5_intf_modes() function to mt7530.c Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 08/14] net: dsa: mt7530: introduce mt7530_probe_common helper function Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 09/14] net: dsa: mt7530: introduce mt7530_remove_common " Daniel Golle
2023-04-03 1:19 ` [PATCH net-next v2 10/14] net: dsa: mt7530: split-off common parts from mt7531_setup Daniel Golle
2023-04-03 1:19 ` [PATCH net-next v2 11/14] net: dsa: mt7530: introduce separate MDIO driver Daniel Golle
2023-04-03 1:19 ` [PATCH net-next v2 12/14] net: dsa: mt7530: skip locking if MDIO bus isn't present Daniel Golle
2023-04-03 1:19 ` [PATCH net-next v2 13/14] net: dsa: mt7530: introduce driver for MT7988 built-in switch Daniel Golle
2023-04-25 15:51 ` Philipp Zabel
2023-04-25 16:11 ` Daniel Golle
2023-04-26 7:44 ` Philipp Zabel [this message]
2023-04-03 1:19 ` [PATCH net-next v2 14/14] dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switch Daniel Golle
2023-04-03 9:20 ` [PATCH net-next v2 00/14] net: dsa: add support for MT7988 patchwork-bot+netdevbpf
2023-04-03 17:08 ` Arınç ÜNAL
2023-04-03 17:42 ` Daniel Golle
2023-04-03 17:50 ` Arınç ÜNAL
2023-04-03 18:13 ` Daniel Golle
2023-04-03 18:26 ` Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426074453.GD4724@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Landen.Chao@mediatek.com \
--cc=Sam.Shih@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).