From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BD40C77B78 for ; Wed, 26 Apr 2023 07:46:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1iWVBomW2jq1pZGfnrJyd2LDMrJPvsG8Mai5Ohv8LXY=; b=bbV4fbmF20pNeF 7WnTOH68kavySjes3xu2juJAc+pL8wkD1HJTrc3Cvxcn/zy1Fqd4zxIo+0HRAi5D7hxknbygSBsS/ T/u7fHU/V7Le76m2D37AvaRC9X7gM7y5TsuMZLRtO+CcrLFatV/fQy2bZR5bKnS1NX9IqOrUirxlg zYSQbw/3e4onqNtUt8iE/qB4FfIIQDiM++4VCvD0TbbcVtiuPce/FqhfWGwhI7wNgzaOYaH+i5fv6 1yNjZzFzzAb2dEtPdDnwebKkuZJUqhLq6mDsdT9U3eTDU8oaVSIEwNMaNhgp6tG/pmWuDwmeku7ja +hBmoMf4tXOEAVUfnzWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prZpq-0035eC-2y; Wed, 26 Apr 2023 07:45:06 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prZpn-0035cc-2W for linux-arm-kernel@lists.infradead.org; Wed, 26 Apr 2023 07:45:04 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prZpl-0001uX-Ky; Wed, 26 Apr 2023 09:45:01 +0200 Received: from pza by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1prZpd-0001gO-Ow; Wed, 26 Apr 2023 09:44:53 +0200 Date: Wed, 26 Apr 2023 09:44:53 +0200 From: Philipp Zabel To: Daniel Golle Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sean Wang , Landen Chao , DENG Qingfang , Russell King , =?utf-8?B?QXLEsW7DpyDDnG5hbA==?= , Sam Shih , Lorenzo Bianconi , John Crispin , Felix Fietkau Subject: Re: [PATCH net-next v2 13/14] net: dsa: mt7530: introduce driver for MT7988 built-in switch Message-ID: <20230426074453.GD4724@pengutronix.de> References: <20230425155137.GA19130@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: pza@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230426_004503_815112_FE762389 X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On Tue, Apr 25, 2023 at 05:11:36PM +0100, Daniel Golle wrote: > On Tue, Apr 25, 2023 at 05:51:37PM +0200, Philipp Zabel wrote: [...] > > Please use devm_reset_control_get_exclusive() directly. > > > > > + if (IS_ERR(priv->rstc)) { > > > + dev_err(&pdev->dev, "Couldn't get our reset line\n"); > > > + return PTR_ERR(priv->rstc); > > > > Not sure if this can actually happen, but there is no need to warn on > > -EPROBE_DEFER. You could use return dev_err_probe(...) here. > > Thank you for your comments. The series has already been picked to > net-next. Unless you want to send the suggested changes yourself, I will > prepare another series with your suggestions, and also apply them to > mt7530-mdio.c. That would be great, thank you. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel