From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4257C77B60 for ; Wed, 26 Apr 2023 12:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mhgR9rno+UWYUrxk7dqiBgsS4OzvNfvC+g4RH9i+Nos=; b=YiSiWPob8rI7pR 4GWAfBF/jTQyIto9Od4L2ckdweYotLFy1HXhH1f8JH6VqVevNihlRmtIpXgPgPbn1RYfiq9pedcMk 8GqvVNOraZl2VBFZBYmfUzblFOIA4xW5KpYbi+DCBkbWVtWdSlALJ5uq4E5G+MNCYlIkDbLlbQdRt GnkOETfkEwoPqWWw+ICQN7FFvt9E1p+iFFCtQNoftz+F6ioPCvNJSkLNIAwoBBaUB7PLZR29It2Wy w9wSaTBuE3WynHgXN9WLbf/pqWbroejyQ4j8uCF9QFGQ4oE3qnCD3Kwp7i88YfqMlu2b5B5/KcRgK xG2JOAvn7lo/WXiw4cIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1precq-003yfQ-1V; Wed, 26 Apr 2023 12:52:00 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1precn-003yeL-0E for linux-arm-kernel@lists.infradead.org; Wed, 26 Apr 2023 12:51:58 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33QCpjB5081412; Wed, 26 Apr 2023 07:51:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682513505; bh=PXu6mMY70bAxJC8Rrl61uY8f0WiVWVlth9TV8MzTHjc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=nlM/1wonloaPs1Lw00YmrHZCgJBYpqRUsmDYJcNhfCS0enDnGABBhkSsrORqJsn73 gZTf47NDGiNgdD60LJ65tBKNMzgKZAzT0yaJgVUFNVZlf8KhECzt7N8Hg4btniSwUc I5bNDSO5GdV2u8q/yaLfL1i+f72CQ94q5jd2E7ro= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33QCpjxe119591 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Apr 2023 07:51:45 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 26 Apr 2023 07:51:45 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 26 Apr 2023 07:51:45 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33QCpjv8040081; Wed, 26 Apr 2023 07:51:45 -0500 Date: Wed, 26 Apr 2023 07:51:45 -0500 From: Nishanth Menon To: Udit Kumar CC: , , , , , , , , Subject: Re: [PATCH 3/5] arm64: dts: ti: k3-j7200: main_pmx0 clean up Message-ID: <20230426125145.wb6qbhb3c7igx45j@seldom> References: <20230426103219.1565266-1-u-kumar1@ti.com> <20230426103219.1565266-4-u-kumar1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230426103219.1565266-4-u-kumar1@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230426_055157_192549_E91140B7 X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:02-20230426, Udit Kumar wrote: > This patch removes duplicated define of main_i2c0 > and adds main_uart0 pin mux. > > Signed-off-by: Udit Kumar > --- > arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > index 63633e4f6c59..37eb24d69924 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > @@ -107,10 +107,12 @@ J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ > }; > > &main_pmx0 { > - main_i2c0_pins_default: main-i2c0-pins-default { nice catch, but We should clean up the reference in common-proc-board.dts, which would make it it's own patch. Also indicate that the definition is already present in som.dtsi > + main_uart0_pins_default: main_uart0_pins_default { > pinctrl-single,pins = < > - J721E_IOPAD(0xd4, PIN_INPUT_PULLUP, 0) /* (V3) I2C0_SCL */ > - J721E_IOPAD(0xd8, PIN_INPUT_PULLUP, 0) /* (W2) I2C0_SDA */ > + J721E_IOPAD(0xb0, PIN_INPUT, 0) /* (T16) UART0_RXD */ > + J721E_IOPAD(0xb4, PIN_OUTPUT, 0) /* (T17) UART0_TXD */ > + J721E_IOPAD(0xc0, PIN_INPUT, 2) /* (W3) SPI0_CS0.UART0_CTSn */ > + J721E_IOPAD(0xc4, PIN_OUTPUT, 2) /* (U5) SPI0_CS1.UART0_RTSn */ > >; > }; > > @@ -163,6 +165,8 @@ &main_uart0 { > status = "okay"; > /* Shared with ATF on this platform */ > power-domains = <&k3_pds 146 TI_SCI_PD_SHARED>; > + pinctrl-names = "default"; > + pinctrl-0 = <&main_uart0_pins_default>; > }; > > &main_uart1 { > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel