From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0320AC77B73 for ; Thu, 27 Apr 2023 08:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MOCOHivgGCh/bclUUrwho7fqdwgPB/jPmIj0QKWgcfg=; b=XV8lWF5U9D+ftB 0HLc8Dr2ocZBxGuci6artilk+a5jWUtFVCGWX5J9HctME5q62DjiZeBHvwdmPahuPAoTRBR9Uuriu 5nNrmLvyetwC/SAF5qKhFEScRplU1h5nIuPKTU91zFW/38Sz/gf85VallXV4zkic3JdQRqcX6JFDw ZkjcthFvF7gZQekkGhr3FVh3Lg3dkzweeDv2z6bT+AkKynHVV0SI2CGmVNyLYxkzkQNhSCme2j6cJ ATc95yfE5MU57uS6sjKiMhSXiK1p9oNk0T5wemcn/SAFustcR1INvebsIDyXSwfc9WO6r4K6ZBuUH +mJg35p/qXJonSotiKOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prwYj-005kcb-2U; Thu, 27 Apr 2023 08:00:57 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prwYe-005kbr-1I for linux-arm-kernel@lists.infradead.org; Thu, 27 Apr 2023 08:00:53 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 319BD80A4; Thu, 27 Apr 2023 08:00:51 +0000 (UTC) Date: Thu, 27 Apr 2023 11:00:49 +0300 From: Tony Lindgren To: Udit Kumar Cc: nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, m-chawdhry@ti.com, n-francis@ti.com Subject: Re: [PATCH 1/5] arm64: dts: ti: k3-j7200: Add general purpose timers Message-ID: <20230427080049.GH14287@atomide.com> References: <20230426103219.1565266-1-u-kumar1@ti.com> <20230426103219.1565266-2-u-kumar1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230426103219.1565266-2-u-kumar1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230427_010052_483978_57D90913 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Udit Kumar [230426 10:38]: > There are 20 general purpose timers on j7200 that can be used for things > like PWM using pwm-omap-dmtimer driver. There are also additional ten > timers in the MCU domain. ... > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 331b4e482e41..1c09e442b379 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -34,6 +34,126 @@ k3_reset: reset-controller { > }; > }; > > + mcu_timer0: timer@40400000 { > + compatible = "ti,am654-timer"; > + reg = <0x00 0x40400000 0x00 0x400>; > + interrupts = ; > + clocks = <&k3_clks 35 1>; > + clock-names = "fck"; > + assigned-clocks = <&k3_clks 35 1>; > + assigned-clock-parents = <&k3_clks 35 2>; > + power-domains = <&k3_pds 35 TI_SCI_PD_EXCLUSIVE>; > + ti,timer-pwm; > + }; Oh so also the MCU timers now have interrupts, nice. Can you please check if what we have in the comments the other SoCs in the dtsi files for MCU timers not having routable interrupts is correct? Also, should the MCU timers be still tagged with status = "reserved"? See the comments in k3-am62-mcu.dtsi for example for both questions. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel