From: Lee Jones <lee@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] dt-bindings: leds: Drop redundant cpus enum match
Date: Thu, 27 Apr 2023 18:17:22 +0100 [thread overview]
Message-ID: <20230427171722.GG620451@google.com> (raw)
In-Reply-To: <20230424151437.256073-1-nm@ti.com>
On Mon, 24 Apr 2023, Nishanth Menon wrote:
> Commit e91a4d5deb96 ("dt-bindings: leds: Document commonly used
> LED triggers") introduced a enum match for cpu, while a pattern
> '^cpu[0-9]*$' already exists.
>
> This causes linux,default-trigger = "cpu" to have more than one match
> and generates the following dtbs_check warning:
>
> arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: leds: led-2:linux,default-trigger: More than one condition true in oneOf schema:
> {'$ref': '/schemas/types.yaml#/definitions/string',
> 'oneOf': [{'items': [{'enum': ['backlight',
> 'default-on',
> 'heartbeat',
> 'disk-activity',
> 'disk-read',
> 'disk-write',
> 'timer',
> 'pattern',
> 'audio-micmute',
> 'audio-mute',
> 'bluetooth-power',
> 'cpu',
> 'flash',
> 'kbd-capslock',
> 'mtd',
> 'nand-disk',
> 'none',
> 'torch',
> 'usb-gadget',
> 'usb-host',
> 'usbport']}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'},
> {'items': [{'pattern': '^cpu[0-9]*$'}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'},
> {'items': [{'pattern': '^hci[0-9]+-power$'}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'},
> {'items': [{'pattern': '^mmc[0-9]+$'}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'},
> {'items': [{'pattern': '^phy[0-9]+tx$'}],
> 'maxItems': 1,
> 'minItems': 1,
> 'type': 'array'}]}
>
> Drop the explicit match against cpu since the pattern match already
> covers the same.
>
> Fixes: e91a4d5deb96 ("dt-bindings: leds: Document commonly used LED triggers")
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-04-27 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 15:14 [PATCH] dt-bindings: leds: Drop redundant cpus enum match Nishanth Menon
2023-04-25 13:34 ` Manivannan Sadhasivam
2023-04-25 18:55 ` Rob Herring
2023-04-27 17:17 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427171722.GG620451@google.com \
--to=lee@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).