From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B517EC77B61 for ; Fri, 28 Apr 2023 21:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=V2L9NgS3I4PHJOCFFQEyXC7XmCsZ4TTPNvd6hO6hwVA=; b=I+z0dK5YbET64b H6WV1NaHXehDN30dbfaJPnu79OMQKgB02EG7vCsMJvyVZMRBlTWOv21kOyutVYF3e+japFIflFTyf sh2cklRzJ3Slsv4l2XJYP0Zt13xlmsu1BSrA8TXbbHhUTNP0JWT8UeGJCKTL7Qgcg7NCEsn6fEneG ZDAjj/POHJZcdKc+qgnSwhKhyxF9dEWVxUvgXIPX27f/f8aPCWfEmIkr2pbszSzhoSUidcYEhH0Jd axLELFu7vsBQNkSitgVXp5mkliJJqnUG0QucmtUf5BYPRoKtyHEyTnwiDL+00B3yka8D0k9e5Ge1H FNPrib4zKiBm6wXKjoRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1psW0b-00BpXa-1T; Fri, 28 Apr 2023 21:52:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1psW0Z-00BpX7-1N for linux-arm-kernel@lists.infradead.org; Fri, 28 Apr 2023 21:52:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA5236412C; Fri, 28 Apr 2023 21:52:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1666EC433EF; Fri, 28 Apr 2023 21:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682718721; bh=7O0Ned+q8ZPBB8k9Xsvo1WnJ6w0vF5mKxj1ue/l/84E=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=iTc5xlR/sYKg5kfAIuSF+qH8xR/12KpzXW/JWJKxFGx6KoVLMC5SQC3XZGEUatNBy qxHxopoaTIxYs5y0h5IiFGDmE6jegNNDxWExCMesp1KPbrPScCx0scKsi89Q2mtma7 CEzHIftjJ2IENV5Oa+PrQzchU9nSUZpyIzawNh4y8BEHyDnBVHw2u+gDiFAyLU7dQS 7Di+G9J1V6k+ud9xPsdWBXF+Dkbu2UQCAk1VYMAgoPK8wHCGXqZVci8353+kEHs6i9 lyQdGmgsfYSJLbuzqyYwBZYfAZVADY+iGHvCaQqFaoh/xguzlkGzvXWJru9go150Ha CW8iqrmcdcqJQ== Date: Fri, 28 Apr 2023 16:51:59 -0500 From: Bjorn Helgaas To: Frank Li Cc: Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , open list , imx@lists.linux.dev Subject: Re: [PATCH 1/1] PCI: layerscape: Add the endpoint linkup notifier support Message-ID: <20230428215159.GA369421@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230420221117.692173-1-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230428_145203_503464_00D5576B X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 20, 2023 at 06:11:17PM -0400, Frank Li wrote: > Layerscape has PME interrupt, which can be use as linkup notifer. > Set CFG_READY bit when linkup detected. s/use/used/ s/notifer/notifier/ > +/* PEX PFa PCIE pme and message interrupt registers*/ s/pme/PME/ to match other usage and spec. > + dev_info(pci->dev, "Detect the link up state !\n"); > + } else if (val & PEX_PF0_PME_MES_DR_LDD) { > + dev_info(pci->dev, "Detect the link down state !\n"); > + } else if (val & PEX_PF0_PME_MES_DR_HRD) { > + dev_info(pci->dev, "Detect the hot reset state !\n"); No spaces before "!". Omit the "!" completely unless these are unexpected situations. They seem ordinary to me. Would probably be better as just "Link up", "Link down", "Hot reset". Or "Link up state detected" if you want. > + dev_err(&pdev->dev, "Can't get 'pme' irq.\n"); > + dev_err(&pdev->dev, "Can't register PCIe IRQ.\n"); Capitalize "IRQ" in both the above message and this one. No "." needed at the end. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel