From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AB4BC7EE22 for ; Wed, 3 May 2023 12:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wtGDNgARxonnj+KK6nxTGlyrPqPEGUw6648LJFCUOM4=; b=utjNa+olN1Croc jnyFX4cErJIZajhkqZpFmf8Uj3eRGiGNbM2VNbCusuC1gB8TkD7spR3GbxGEYfHmAQxMPYKz2FCSr +3IPu0VvkkXU5fygei+f3hdRCaXOsNztce0ta0ytXoffoaNv28C35owKQrG01ZtplmvioQ/ATBOpk iEGHZvNdxF0AzDiui5/xeJNnEQx5ngMpTzMG2EGftyaSHIGmIiMIjfgQVOtX9oS/K26WwG9V7jBrl k1Fy1CIGFuUh+x7vBGNZcwB73BVWoGdQl3CLNkWPLmRBPWOS0TayjQX/pSLpe4vDeJg38pFcmKEVl uWJV1YJ7aB+g8pC/2GOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puBsu-004bGY-05; Wed, 03 May 2023 12:47:04 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puBsr-004bEk-07 for linux-arm-kernel@lists.infradead.org; Wed, 03 May 2023 12:47:02 +0000 Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F3197FC; Wed, 3 May 2023 14:46:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1683118010; bh=8tpFe1mRbMpuQYRWmCcz3C5R1eFk43c/5w1n3EfEaUs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FhsmWa0sixUOzftKQtwho5RwLw2gOXgSmC/P3VXYP2UI9aw/85Eaqy5FPSijbOC9Q Z6hqQusspQI8XN7J+lWSjQitUoyIsEKOuQQYH4KMgNvF0ZWXFJ8WlL8FD2ySmU+yIm VcvSd90WihXf3Wb2Al9wGPMqSlc0jKf0hDvmIZ9M= Date: Wed, 3 May 2023 15:47:06 +0300 From: Laurent Pinchart To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com, Harini Katakam , Krzysztof Kozlowski , Michael Grzeschik , Radhey Shyam Pandey , Rob Herring , Robert Hancock , Sai Krishna Potthuri , Tanmay Shah , Vishal Sagar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Revert "arm64: dts: zynqmp: Add address-cells property to interrupt controllers" Message-ID: <20230503124706.GD32586@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230503_054701_243419_4BF09837 X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, Thank you for the patch. On Tue, May 02, 2023 at 03:51:01PM +0200, Michal Simek wrote: > This reverts commit c6badbd2d321c19d4f55ee56b0ef12bb3352feac. > > Long time ago this was discussed with Rob at link below that there is no > need to add address-cells to gpio and interrupt nodes that's why reverting > this patch for ZynqMP. > Also there is no visible DTC warning which was seen in past. > > Link: https://lore.kernel.org/r/91e3405245c89f134676449cf3822285798d2ed2.1612189652.git.michal.simek@xilinx.com > Signed-off-by: Michal Simek Reviewed-by: Laurent Pinchart > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 51b8349dcacd..2d564ba7e9e4 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -419,7 +419,6 @@ fpd_dma_chan8: dma-controller@fd570000 { > > gic: interrupt-controller@f9010000 { > compatible = "arm,gic-400"; > - #address-cells = <0>; > #interrupt-cells = <3>; > reg = <0x0 0xf9010000 0x0 0x10000>, > <0x0 0xf9020000 0x0 0x20000>, > @@ -633,7 +632,6 @@ gem3: ethernet@ff0e0000 { > gpio: gpio@ff0a0000 { > compatible = "xlnx,zynqmp-gpio-1.0"; > status = "disabled"; > - #address-cells = <0>; > #gpio-cells = <0x2>; > gpio-controller; > interrupt-parent = <&gic>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel