From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A882BC7EE21 for ; Thu, 4 May 2023 09:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LftGiTDaM49b9lLyTIOLTgWU4/bianrp0rcktIPdPK0=; b=lkx6iaYRx205Hm 668gMn3lCMprV5ildDaa7vA3Z6l9JD9IPy8CVkEDIhzgNEjMluPfB+1fs2i5xUsmlklTgscvPFl0X 9Xig8IHTSORJ1pcIuTiwZ9pU/LcP/i9McfYEhSq1Bx9pLe/qbjA4BAyqRAKK5hNQp5rNIS6j365wb e4d6uIyEpmLNZ0yQo/tgRgw54nGHtXkg+j6TGLa5JmFIDfiXCiBEfb++SDq0nXEAZP9w5YJv6Gljq nHrT87QqGPZ3tX0DTDgBWEpCUbkm3uOhrKz5HFM+muQ1vhBzEzTEDx27Fac6ThMshrgfFShztvDc9 gqeEe0WSeYyXD4OxvPvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puUzM-007DK2-15; Thu, 04 May 2023 09:11:00 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puUzI-007DIl-2i for linux-arm-kernel@lists.infradead.org; Thu, 04 May 2023 09:10:58 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DC470320093C; Thu, 4 May 2023 05:10:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 04 May 2023 05:10:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1683191447; x=1683277847; bh=PJ +MHi8BKY86SWPKwEBcexmDQBI0jwalX3S/C8DpKjY=; b=OkJR1vdZgMQkDeebk3 C3Df+sYUG5IKzDgGWDzP54zncGqO5dMLxISsW9MRjxlY5mHfYkUosVFISdiAJC41 ptg80omXiJjpzbcGf/6DhvjIn1eqC1+wvpu/5OT2tQWg8AYOOvRWmmDVXe5CIyXZ oMVx1/RfSd1AItwWlg09Ew7QN1J4tXCFvBSfBWwDfZsZz9HiZEPjApUSpmc67qn5 VKU3dzluckNiasW3k8s8dB0zCyAzpzG1biELtAfSYiV4fhem/mrTc8/qHqoTsK1/ WwXwanX5JmQ95ShHqkQ+1+pCiJtTw4ra0fpqregHs8hgGZFfuqpaXbrsJT1ZdiO1 EpQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683191447; x=1683277847; bh=PJ+MHi8BKY86S WPKwEBcexmDQBI0jwalX3S/C8DpKjY=; b=Np0mbT/tXdr6/OFl02CaRMdgq4uO3 5QiemDuzsd15WsbMN7h8d01YHCLQ7nl+fK/OgrKX1t+/g0YX3WjFOaF3ZXyIR+sC JaESqTvBVva9CyxXaNLmmuvCoVHN8icnPWd9T69BpaNEupv4+AsUVLG/mDdspWnz iWHSGMWirMO+LxTBASSccT5yHfQ+68t6zOBcHWLBbogN39+gwFUhh+4TnwTrGdzu RLKH+hYcf9rZn6rVa8ItUCosIV9b0ZS6I5Gs5g3fwNv2eCn/V3YRgstZXgRft1LF NQR4+V+AGasKMB3MI7ALGaHbpAb6xhCKYc1l2akYUSNoRkqhDn3n3JpPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeftddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepheegvd evvdeljeeugfdtudduhfekledtiefhveejkeejuefhtdeufefhgfehkeetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 May 2023 05:10:46 -0400 (EDT) Date: Thu, 4 May 2023 18:10:42 +0900 From: Greg KH To: "Peng Fan (OSS)" Cc: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH] clk: imx: imx93: introduce clk_bypassed module parameter Message-ID: <2023050410-rejoin-vocation-8560@gregkh> References: <20230504085506.504474-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230504085506.504474-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_021057_352387_94ABCA28 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 04, 2023 at 04:55:06PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > With the clk names specified in clk_bypassed module parameter, give > user an option to bypass the clk from managing them by Linux kernel. As I said on another email, no, please do not add new module parameters for drivers, this is not the 1990s Also, another comment below: > @@ -310,6 +357,8 @@ static int imx93_clocks_probe(struct platform_device *pdev) > > for (i = 0; i < ARRAY_SIZE(root_array); i++) { > root = &root_array[i]; > + if (unlikely(imx_clk_bypass_check(root->name))) > + continue; Only ever use likely/unlikely if you can measure the difference. Here on a probe function, you can not, this is not needed at all, the compiler and CPU will do a better job over time than you can guess at this. But as this change isn't needed, this shouldn't be an issue either. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel