From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8ED3C7EE21 for ; Thu, 4 May 2023 21:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tjv9g/NJSPevcstpy4BBnrwDGVYI+lh0Nic+mjpDMKo=; b=08xnepyMwR7Ol5 FvXmIjHgjdO6Zpo/hfR4vRHm6ct/0umFWZNPqkvwrz50UQVOVnCIF0frwCuTw3O5rUoJLjHV+w2+N /kAOJGWdGfWGQ1f5ndRoQLlg6gJWHqC3uGPmtyK8u6aCe426e5VDNX1HJit1OAekGAKd2aEktXIZ5 UHv0HJVEJ2Sk5ZZRbTQWhnTuludSGxAsmwJA4HwsyC1DPuGdJpawnQdHiOw5zCmwNfpUw6ZHsjs3U iD/Oa/4IEORbiezdbNd2B0GKbrd9Komg/WwnyP0oQ+UJgI07jwLic3+xrNIh3lxOV6xkcKSr/TL76 cfb6WS2v5YgYBEDfV1zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puggt-0094sF-1g; Thu, 04 May 2023 21:40:43 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puggr-0094rI-38 for linux-arm-kernel@bombadil.infradead.org; Thu, 04 May 2023 21:40:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=ZR94RLdgZZe/12kss7J1iM6+A8jp2ZRBIXDD2YuUQX8=; b=WIFtSjgBPSPt6JTzQ9yg3uM+iK 1CBECGAzdzwRsRMeccNWeyXMlNtQLFsY9ez4+UxN6JeE8nUo7oywHgw4HVBDrcZA1GuqwcVVrNwUi 8/9+CVArXdQ9RmkoxHYwDD/kKHqost3P6mW5T+wIryinHLPFxOvVBf1+e4GmoqxaCqyIxwPPE9mb/ 0/G3ByKY7ZZ5uKimRqPXJgD8yfa6zruVhP+6qXrnDvoI6TaW2tSIQO+Z0P/T7lnsTK0yU4gnzOIeR ZPOdCFm78OaOYlr698gJr8D1FlmyVChCylSARv3yLjkdt0zQgcBzKzKRKNGJO7zD9vK+bu5Kf8VK/ Qlb7hb+Q==; Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pufc7-001qN9-1S for linux-arm-kernel@lists.infradead.org; Thu, 04 May 2023 20:31:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02ADC616F2; Thu, 4 May 2023 20:31:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAE0CC433D2; Thu, 4 May 2023 20:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683232301; bh=AMX9eSGT0Ex1FIrIwXwAGiq+3+mlAoFPTGH7Izm0rJg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rkajFyLTPUkb4Quul9gANHVxIdzIYJE07aUyIjp5xOl8t+BsOUdZ3mcOX1ss/RHeb hHxfskc9yxn9+gwVz7EutctEcclzINK6ehSlG15ZuWF2p/y0e5LX82dEvjnFU216wM uRuSEgsOTCqJECOa8eEOwF59qeRz7l1IVZ99Nt6NF3H9JJl9eri5SvDBLjweBzf15L +CJw4QCPLKW5W0sXi76FRe+OhsLRTKPoefkTx0CC5wayU0o8IpcVrK7TgDrxe1BxuM kVdmbCDllsdd1hhvE0Rqh/kREEpL3tZS3sjKt3AD5x01hc839xQ39bwaDWPokaOCEB 8Iyy5/LLcV2Fg== Date: Thu, 4 May 2023 13:31:40 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , , Jiri Pirko , , , , Subject: Re: [RFC PATCH v7 7/8] netdev: expose DPLL pin handle for netdevice Message-ID: <20230504133140.06ab37d0@kernel.org> In-Reply-To: <20230428002009.2948020-8-vadfed@meta.com> References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-8-vadfed@meta.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_213146_215030_89A57B91 X-CRM114-Status: GOOD ( 10.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 27 Apr 2023 17:20:08 -0700 Vadim Fedorenko wrote: > @@ -2411,6 +2412,10 @@ struct net_device { > struct rtnl_hw_stats64 *offload_xstats_l3; > > struct devlink_port *devlink_port; > + > +#if IS_ENABLED(CONFIG_DPLL) > + struct dpll_pin *dpll_pin; > +#endif kdoc is missing. I'm guessing that one pin covers all current user cases but we should clearly document on what this pin is, so that when we extend the code to support multiple pins (in/out, per lane, idk) we know which one this was.. ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel