From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53D5BC77B73 for ; Thu, 4 May 2023 21:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i91MEwT8ofuXjnZD6nS2CSXHNdCg23Pt8+BuURDteGc=; b=4htnvm4ALzUn9Q Ix3q8RfAjvYyrE5wmNVHpfhh+C5fY0XI0Zes5msW5fQp1Ze3ZxdqxDjLH+lYo/fE9ySPhQIJr3UeE roF1x0CbrJf4G5cvHcegEvbPajOzmam+RB1lRPluESBKLBrbdNDmFx+4OmurWD8H8ou7BmKN7spav LLte/FeSnfVcN+d/K/OHsXd0Q/YDQB4JznlkyZZH2MIAEnH0piyi4RKeEXgYSYDSF3XEe/0I5aDDH G8+9q4bh+JwobsNBwwEAWICoidjwBe/91NhnGexx4C6RssOVIg0LzAlDwGWSpPBLCd6rVjUO2Duiz JY7DwfUvTWU18wEZkPDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pugOH-0092Yz-3D; Thu, 04 May 2023 21:21:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pugOE-0092Y2-3C for linux-arm-kernel@lists.infradead.org; Thu, 04 May 2023 21:21:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2084611EF; Thu, 4 May 2023 21:21:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0F21C433D2; Thu, 4 May 2023 21:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683235285; bh=jpSH+u+S0sJbu8VeFrwjvjt3yEARbb7MqiqpyQEzo/c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=axyRJJ5DG2ZmQnBv7WNlCyJgIGdg50EUyrJyFGkxkHEuslHIaLodH66LDWQ8L0Gvl QSg0gcmUdbIsI4hWIZoJlKEPdQzd4LdAfrTjD0/ovcE3FcOEk4vc6XxasU2qGKgSX5 p2nsLQBf78fxpoqXIFGYWxoF/URy4drHcV7bqrKqRtAJ1SmKloi+UELL8VuypMsB+T QrN54MHPzcIpzfrkj2OMmvt4+18MS/3MYp0BDoxY0A98WCkxj2+HfVIcmy/dn1k2k6 DI6bAq60rugYZ9XU5Yk28ovkt+WYmve3eyo9aqJGctYhUvjHUIqSjYWPbVE1Ou51Hc CmlNz8Oms5gYQ== Date: Thu, 4 May 2023 14:21:23 -0700 From: Jakub Kicinski To: Vadim Fedorenko Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , , Vadim Fedorenko , , , , Subject: Re: [RFC PATCH v7 2/8] dpll: Add DPLL framework base functions Message-ID: <20230504142123.5fdb4e96@kernel.org> In-Reply-To: <20230428002009.2948020-3-vadfed@meta.com> References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-3-vadfed@meta.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_142127_071132_AE028F53 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 27 Apr 2023 17:20:03 -0700 Vadim Fedorenko wrote: > +/** > + * struct dpll_pin - structure for a dpll pin > + * @idx: unique idx given by alloc on global pin's XA > + * @dev_driver_id: id given by dev driver > + * @clock_id: clock_id of creator > + * @module: module of creator > + * @dpll_refs: hold referencees to dplls that pin is registered with > + * @pin_refs: hold references to pins that pin is registered with > + * @prop: properties given by registerer > + * @rclk_dev_name: holds name of device when pin can recover clock from it > + * @refcount: refcount > + **/ > +struct dpll_pin { > + u32 id; > + u32 pin_idx; > + u64 clock_id; > + struct module *module; > + struct xarray dpll_refs; > + struct xarray parent_refs; > + struct dpll_pin_properties prop; > + char *rclk_dev_name; > + refcount_t refcount; > +}; The kdoc for structures is quite out of date, please run ./scripts/kernel-doc -none $DPLL_FILES > +/** > + * dpll_device_notify - notify on dpll device change > + * @dpll: dpll device pointer > + * @attr: changed attribute > + * > + * Broadcast event to the netlink multicast registered listeners. > + * > + * Return: > + * * 0 - success > + * * negative - error > + */ Let's move the kdoc to the implementation. I believe that's the preferred kernel coding style. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel