From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17385C7EE21 for ; Thu, 4 May 2023 16:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ym+JshVUC4tpNI8P1iIrLwfndSF9GZSji3IsOwZwGk=; b=ATtZTM2dGR3u+9 t02hrjuTO9PNO6I3+WtdcKHeY/9VTjafJpe+d/Jl8/ph6toQmCmDFl9XioV+R/eMc/SLh6Zp4E98o NPUTnjRWae5Nwsdlc6hFGSfEKI0XWl6rjSyjAAqK4/Jc2gPqj6a82xwpjbAEdUfr5cTUm5t6+cG6a +NdVLPKfaiCjjY2tayl0MBZBEyfMTJDDubI7dYTZ0RujZaFo0qMUDtfHJV8S4A6LXlHyTb6sXGCKm JWoOHqhMCVc2wNVKDgZH1bOoK0+cCteM1G9yj9d9oGsAPQ3JG+csEoDseH9Fpow6WypY20t1UtSaR SeMNIxEtGigaoysDM00w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pubjp-008K8n-0v; Thu, 04 May 2023 16:23:25 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pubjm-008K6h-2F for linux-arm-kernel@lists.infradead.org; Thu, 04 May 2023 16:23:24 +0000 Received: from booty.fritz.box (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPA id B2BF5C0007; Thu, 4 May 2023 16:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1683217395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wiCrz2ZRJmlknjS2A3op5qUSsF1/r0N1+dDlTFVnvnE=; b=ehp8Vtl2YknxMApsjQ51QluNSkt0kStbvIacHCS6HpgBi30SX0QmHASf05KUC2vQq0SQaS nOo0WJESWYwe/ZhBt66skVyMrslAHsB5sPpWQukCeB7HNjaejeN/EZM1Zg7ClZtGAIJVSX T1D055JNe3iJy108yRmGnEfkqmQ2cHV+61PxOeDtgHPpabPX1cumhMKJ0+XOs/dw26Yn1t aGwjc9Vke5F9P+/ka8h8DO4BoW/Gmhdpl2+1KRb5hRXmGsWdvuyEogWO7cB3P9Mhyi5p+O H7ofWPxyGkCguu1+hUeUb3XpXca5sh8sP9dhr9+2zpFLxr3qZjtWBAbGVqJZJw== From: Luca Ceresoli To: philippe.schenker@toradex.com Cc: devicetree@vger.kernel.org, festevam@gmail.com, gregkh@linuxfoundation.org, jun.li@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, peter.chen@nxp.com, robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm Date: Thu, 4 May 2023 18:23:12 +0200 Message-Id: <20230504162312.1506763-1-luca.ceresoli@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <23672d66d229d3be4cc854ddf1462c3507f1c2fc.camel@toradex.com> References: <23672d66d229d3be4cc854ddf1462c3507f1c2fc.camel@toradex.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_092322_906445_616CE988 X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Philippe, I found this thread after several hours spent in debugging why USB host is not detecting new devices on a custom board using the iMX6ULL Colibri SoM. My best workaround at the moment is: --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -56,7 +58,7 @@ static const struct ci_hdrc_imx_platform_flag imx6sx_usb_data = { }; static const struct ci_hdrc_imx_platform_flag imx6ul_usb_data = { - .flags = CI_HDRC_SUPPORTS_RUNTIME_PM | + .flags = //CI_HDRC_SUPPORTS_RUNTIME_PM | CI_HDRC_TURN_VBUS_EARLY_ON | CI_HDRC_DISABLE_DEVICE_STREAMING, }; so it's equivalent to yours, but hard-coded. I haven't found any follow-up patches from you, so I'm wondering whether you have made any progress on this issue. As I see it, a quirk in the driver would make sense. What needs to be sorted out is how to enable it from device tree. I think a DT boolean as you propose would do, but with a name describing the hardware aspects of it ("chipidea,vbus-detection-is-broken"?) and not the driver behaviour. Otherwise looking for the "toradex,colibri-imx6ul" prefix in the top-level /compatible strings seems doable. I don't know how acceptable this is from a driver maintainer's point of view though. Best regards, Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel