From: Sam Ravnborg <sam@ravnborg.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
kernel@pengutronix.de, Boris Brezillon <bbrezillon@kernel.org>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@gmail.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/53] drm/atmel-hlcdc: Convert to platform remove callback returning void
Date: Sun, 7 May 2023 18:44:05 +0200 [thread overview]
Message-ID: <20230507164405.GA858368@ravnborg.org> (raw)
In-Reply-To: <20230507162616.1368908-7-u.kleine-koenig@pengutronix.de>
On Sun, May 07, 2023 at 06:25:29PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-07 16:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de>
2023-05-07 16:25 ` [PATCH 05/53] drm/aspeed: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 06/53] drm/atmel-hlcdc: " Uwe Kleine-König
2023-05-07 16:44 ` Sam Ravnborg [this message]
2023-05-07 16:25 ` [PATCH 10/53] drm/imx/imx8*: " Uwe Kleine-König
2023-05-08 2:43 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 18/53] drm/exynos: " Uwe Kleine-König
[not found] ` <CAAQKjZN0DpnjpybZaEYz=eS4khTbY7RdS4i0-rC_-O_jk1iY-g@mail.gmail.com>
2023-05-15 9:16 ` Uwe Kleine-König
2023-05-19 0:11 ` 대인기
2023-05-19 6:38 ` Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 21/53] drm/imx/dcss: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 22/53] drm/imx/ipuv3: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 28/53] drm/mediatek: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 29/53] " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 30/53] drm/meson: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 32/53] drm/mxsfb: " Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 38/53] drm/rockchip: " Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 42/53] drm/stm: " Uwe Kleine-König
2023-05-15 13:53 ` Raphael Gallais-Pou
2023-05-07 16:26 ` [PATCH 43/53] drm/sun4i: " Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 53/53] drm/xlnx/zynqmp_dpsub: " Uwe Kleine-König
2023-05-08 2:35 ` Laurent Pinchart
2023-09-09 14:37 ` [PATCH 00/53] drm: " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230507164405.GA858368@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).