From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5549C77B7D for ; Sun, 7 May 2023 16:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yAjh61yqQrZmsRVgbnIyTal8RlgnE3iFyPxn9ctQHBg=; b=3uw+1Aj9twZekZ 7PLZS9aWhvMPt4KAEK2ghhegr3eDkFeJ7rURS0k1QEsqCJVJppy97CZGFAeN8aDjTfOvAOxSIfSPk ZGppbFIDSd9FmI+Z0aNeIiEAHHJVKvZ6RrJaYycJSU1U2Yl8qjbGy3UprR/R5fl4NhEbnZwk6i5je ZBPKrHzvX18RuAOXDSAm9VLg8D8EVA4pGB/mq4sK0Zpe6vxs0rVkDbC3MzA7uUkyTEb2txlMsaEz1 cZ6vBV8h0meBZpKw3HZERSvnRItikzpOmgH8gsb5MHiVSLZNIhmhryhH2sXy92hD4gFwTQ7M3EKhS /CkCwD18c3ZcBHmTUB8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvhVl-00GQ5a-2S; Sun, 07 May 2023 16:45:25 +0000 Received: from mailrelay1-1.pub.mailoutpod2-cph3.one.com ([46.30.211.176]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvhVg-00GQ4G-1I for linux-arm-kernel@lists.infradead.org; Sun, 07 May 2023 16:45:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=ucA11er79JBET5xWuYyOksM1zu8wU5kPeOrR5aA/0dU=; b=PRgP9Y4tNwXHXZxrzXrZXQOQJrTWVbnnddZMPB2mk9pAZH6bVYon8BkwVTrI0xZh245CSp7c/MQzS qJJmpiAjYG0AjFK7avHGfYI7/rB5q9zPm3GvyAG2LRfU++rlb+5vx8IUQO9W5lovDNzCdGKEWrMvkQ pbCZMyd0+LOsePy4H6RvzrlHamNmJ95+z0nYYKHVZ3siwQDkmjr4Ocdecf3oJRbOxHpra0AilaEm5v OCysPHPCKUEK8kT+WCqKWxre06jOsHPP3Py2HVgaOEbGdbSgdm2rdeknHn9m9tdtfKMR1xC4vecCcN ipYG1RBWXnWrElU0KMFu4eXFixtn+Dg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=ucA11er79JBET5xWuYyOksM1zu8wU5kPeOrR5aA/0dU=; b=IIfp1nrbe2FTNGrkX3vZSeZbg/t4CNFhhhF36p6dbnAwlRmjsD8D1hGKpg5r6+b/bKcpaheCbFQuD aNAvqmVDA== X-HalOne-ID: 605f2960-ecf6-11ed-a290-99461c6a3fe8 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay1 (Halon) with ESMTPSA id 605f2960-ecf6-11ed-a290-99461c6a3fe8; Sun, 07 May 2023 16:44:07 +0000 (UTC) Date: Sun, 7 May 2023 18:44:05 +0200 From: Sam Ravnborg To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 06/53] drm/atmel-hlcdc: Convert to platform remove callback returning void Message-ID: <20230507164405.GA858368@ravnborg.org> References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> <20230507162616.1368908-7-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230507162616.1368908-7-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230507_094521_825606_786DAE0C X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , kernel@pengutronix.de, Boris Brezillon , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 07, 2023 at 06:25:29PM +0200, Uwe Kleine-K=F6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Sam Ravnborg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel