From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1A7CC77B7A for ; Tue, 16 May 2023 19:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pV/g27iSKE3FRV/mbFq6GVp3muvseHL8PcneFCTmElE=; b=KvZgTOoOWD4oJ9 cbLPmX8YtIhUsjQn6ytc6j0wHrqAmgl0dnH207+Z1r7MiMUYgOnjCOmKVFJULaJR8XgoXfwwfOtcd IMwFACN1W++Bxy6SgVT56WkiYLnsqtJbAjBnE4vip5bXFdICKwysaaRL1j+ogoWqD9UE31CIeOo3f jszXLwSTZwv2qzOsrNpNkor/f3ybiCIwifaLyHok1hg43sC9j2Q/bQdcoYtOsYvCPl97kEBTIJyTZ WxPmiF2hRKJaYxIBcDMLNImUhsdmW4ZUrytBSer/bw5g//efb0wspExXMDQgcM7/2Q0Jdj3M7EVc4 cul+3S+zhdzwPgjnbK9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pz0mq-006z8x-1j; Tue, 16 May 2023 19:56:44 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pz0mo-006z7I-22 for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 19:56:43 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-64a9335a8e7so8298358b3a.0 for ; Tue, 16 May 2023 12:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684266999; x=1686858999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QlgAAtiyihh7bx5P71pi2o6dPtZSer+A46AGpW/5WPM=; b=kef7EitnyZ6qVVLdsWjYeAdWG/vB35cqybAGBIj/wVTjUV6BlKvSCGjnNbHNOsCEOL h+BT20FpTWmXn29KSAWGRqAhQG7dYi4HpAICRT9xWClylv6xSJEyF5aX71CJi1iWwCBV AskpSJ9ywL4mhKKAIE30RromysT+Wz3FHQz7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684266999; x=1686858999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QlgAAtiyihh7bx5P71pi2o6dPtZSer+A46AGpW/5WPM=; b=LPTs67uNW2kKAqRHgsbqYaujJXjqHE/t/+YGX9oG1BfbLvZTIQ4c26JR6M05S4DXBN PmOBPz2imZc6ITyARdrmbZLtYf+DdQTuEBHIMHhUvM8DIvtlspa9BVnstwSVDamjGZWi V9TBYJlCwaYx8hQhZtnUsfJBai/atfISkkFR7wiCz7MBE41rcBb0t5nrQ2RwzB9MakWn oCtu/IQcqWRlqCh9i+CH/PvRYRR/uqxvj9USPA6HaZf62whJFIGiDfI03Vva+xgFB94Y 74JKDmAj4l2Oc3HZGCN/KaB8njPL6QSb42jgq3f2s6nirDwWkMf/pOxjI0ns/B3OmeJt J4eg== X-Gm-Message-State: AC+VfDyvtGo6ivLVwQQQbQyQ2wqzgraYUTKZVNlDDrxwbsc2tgPeeGcH ZEsz2RGzl4ThmFLbAiy1XkUn9P0Or4RIFDaPcjk= X-Google-Smtp-Source: ACHHUZ504MnZSV1lW6m3lpadzxSZtXTyWWnmbMDexEhPigrkHEzEuE9njCOaI6ApJ1b+OCtl1rWdcQ== X-Received: by 2002:a05:6a00:e8f:b0:643:a6d1:b27 with SMTP id bo15-20020a056a000e8f00b00643a6d10b27mr34066068pfb.15.1684266999152; Tue, 16 May 2023 12:56:39 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id m3-20020aa79003000000b006466f0af9b2sm14238048pfo.179.2023.05.16.12.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 12:56:38 -0700 (PDT) Date: Tue, 16 May 2023 12:56:38 -0700 From: Kees Cook To: Arnd Bergmann Cc: Russell King , Arnd Bergmann , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Oleg Nesterov , "Rafael J. Wysocki" , Pavel Machek , Linus Walleij , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 00/16] ARM: address -Wmissing-prototype warnings Message-ID: <202305161256.F6C079EAA@keescook> References: <20230516154605.517690-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230516154605.517690-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_125642_690645_4FC332AD X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 16, 2023 at 05:45:49PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > This addresses all arm specific warnings outside of the mach-*/ code, > which I've submitted separately. The majority of the patches should be > straightforward, either adding an #include statement to get the right > header, or ensuring that an unused global function is left out of the > build when the prototype is hidden. > > The ones that are a bit awkward are those that just add a prototype to > shut up the warning, but the prototypes are never used for calling the > function because the only caller is in assembler code. I tried to come > up with other ways to shut up the compiler, and ideally this would be > triggered by the 'asmlinkage' keyword as Ard suggested in the past, but > I could not come up with a way to do this. > > All of the warnings have to be addressed in some form before the > warning can be enabled by default. Thanks! These are all long overdue. For the series: Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel