From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93D37C77B7F for ; Tue, 16 May 2023 13:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HaFwcvy4jnRPqs+A5ackFpZ41DbK0jPTj5uKmcjRwXA=; b=ruPB8wkEfMCLXG DBNQdRWJrCGxx+tCgPUMuM7r1NjYRx0XBawz7jz3lzacdtFoZmwVW7LR7VV8sHNMKukSoLHThLmKe jRuJOmy3a1rUWNlyx7u+gi4rEZZoBYCh18QtiCsUABhGaDH1XFgQDbWW/lqugxQop/nI4jWL0PrbZ o+mn7rP/VnWNBcxUfC3ieeE0vEgU31wNu1c8iGxFWBn7RueCMxB8LDz7sHlIPqImiHEHtnPkTkLNQ eXh/HVayKFkXxeU9yfEqo/On3BGfMSvmzMhlrr2WOuocO3AKHG6rQO95AoBAspnns6ZuttvqYcmw0 8sZXMJmUPxj1rnA/x+gA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyufN-005uPS-1h; Tue, 16 May 2023 13:24:37 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyufK-005uNR-37 for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 13:24:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 00428635A7; Tue, 16 May 2023 13:24:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27432C433EF; Tue, 16 May 2023 13:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684243473; bh=v955wWx7frM5aua9JiGRpiLnkxI6iEN+b14qBeS8htg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sbF4guWqOD8mHIzygGiLKs1TaU7izCz1lEHjLaWE7V/evztEOB+OjWPcE3BiAOuTT pJCyHAjzuS1gb73gXYtHeUl8eoJ3AfrvaAOM4FHtXEnB4pJX6JK1V4FH+1rfhdhe7K Iv/sVogMqvtuawf1PYPzqlN45tWiuAAIT2POP5pZjjDneBU/vs5IbadWrBjA6ZkH+R bfegHHga3ojh71j2gPFjSRsVzDpM0f6kh2Y/O5vJo6nyby3VQtXVOGsDs9rXKaMlQ1 YtTag8zfqawlBMWSK4N2q8zauDXiCdiyr/mzBOPquy864Y13ctqoqvvOaJZ1NPIHEB 1UQdYyhc4OnWg== Date: Tue, 16 May 2023 14:24:28 +0100 From: Will Deacon To: ye.xingchen@zte.com.cn Cc: broonie@kernel.org, catalin.marinas@arm.com, kristina.martsenko@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: mm: use bitmap_zero() API Message-ID: <20230516132427.GA30894@willie-the-truck> References: <202305061636313011243@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202305061636313011243@zte.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_062435_060364_A2FBC294 X-CRM114-Status: GOOD ( 17.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 06, 2023 at 04:36:31PM +0800, ye.xingchen@zte.com.cn wrote: > From: Ye Xingchen > > bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero() > instead of bitmap_clear(). Is it? Don't these both boil down to: memset(asid_map, 0, NUM_USER_ASIDS / 8) ? Will > --- > arch/arm64/mm/context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c > index e1e0dca01839..ed0bf7f8e8ce 100644 > --- a/arch/arm64/mm/context.c > +++ b/arch/arm64/mm/context.c > @@ -95,7 +95,7 @@ static void set_reserved_asid_bits(void) > else if (arm64_kernel_unmapped_at_el0()) > set_kpti_asid_bits(asid_map); > else > - bitmap_clear(asid_map, 0, NUM_USER_ASIDS); > + bitmap_zero(asid_map, NUM_USER_ASIDS); > } > > #define asid_gen_match(asid) \ > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel