From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9567CC77B7F for ; Tue, 16 May 2023 20:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TW65hMUEG8pRaHoG6UQNqJxgjjOr6MR0gjNFnet89xQ=; b=n8A0mEvhEBFVPJ rtjGKFBwaIeAveJDvW5W7wd2iSrK0E52xjrqZ4rT3USSSL+6OjvLNo55P1u6HZKzNLStJAZrfAId2 zJH5p7r5r1jjN54oMW24H0Ilt4oIUsRHiyPMzJAwC6DPXSkLDo9WSLOXhsrdG4YBhiyKyS9pDg9K1 9b/JQgrcVqJcYXgzEKPHIkVkHeoihSOIYWh49NW0JTKQexIO8QuQdAuKBP746vACn1lcBFVFmYZKX b05ri4PqYT2Y8R6GJUXAJzCcZ4nGf+hRoie+dFCP70nO2AWoPPpnlWP0joFbVYW5DJe4fwOfvdhjw le9UWC31+G3SPihAyxZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pz1d1-0076E1-37; Tue, 16 May 2023 20:50:39 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pz1cy-0076D7-2H for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 20:50:38 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-53404873a19so2527878a12.3 for ; Tue, 16 May 2023 13:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684270235; x=1686862235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zQwO1AW86ZZMLv1I226cO+hnWHW8xIqRy3E2TLcdclA=; b=fFhG9M9BqB2Jhhucg0HrxXSX2VDAxo8VMXPAmarNkjhKXtKNnIKwpdr5CJY72A6B3n I7Ups187ntxJFuKWvFdd4ZS3604bvLbMPjDvPhSmshRWSMvI9fNpZDE1Jzg7WhICSmZq IlXhZj1G/aY1nBpyMbqOO7qk3Nj2BP+W4FP7g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684270235; x=1686862235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zQwO1AW86ZZMLv1I226cO+hnWHW8xIqRy3E2TLcdclA=; b=cjUY6u3yF2AwyH4ziSTLoRJQg05i9vGDoBMaoMCcnqDJRbnDN+0xb/IwGsQcQxXA7I 2M7UyB2QFj8oVsJmi+rOLL3MNRieaAnmNK3qO2CJ2iPoYn8c9MgtJZow3tiO8pmUOQdk st3sj2k3tRV94BrVC8SmyjOtJJmPq+HGjvz9v+rU+pDnc/su2iOQQEcd+/1bh7P89jid bUofEPJuTZfn+FhBEWZNOeO8pTKxVxO9ZwKKIQrfpgNPU6MnP0KOG3F77WfjWW6HKk9u EO2KFmx/WYMGZm5YTd4lt7rH+X4luDak2Fh5uqRQsUHOupf47vh68BMgZB0J0L4wjX6x 93uQ== X-Gm-Message-State: AC+VfDxkrnkQGp0vub8YsUnjMoiHsP4jm7Mh7xQBCRatHcQ7f4LUnDnq kL8zMRcSSalBHSLyDuvgsHzbFQ== X-Google-Smtp-Source: ACHHUZ7zbSTqF2+Ctw96wBfV5FayFZLDDyPrQ785jpE1+sute7vYZzIO1eBBcnyFwmB5G5I0TAFTNA== X-Received: by 2002:a05:6a20:7d97:b0:ff:e60c:ee93 with SMTP id v23-20020a056a207d9700b000ffe60cee93mr43232036pzj.26.1684270235098; Tue, 16 May 2023 13:50:35 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id i13-20020aa7908d000000b0063f2e729127sm14237746pfa.144.2023.05.16.13.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 13:50:34 -0700 (PDT) Date: Tue, 16 May 2023 13:50:33 -0700 From: Kees Cook To: Mukesh Ojha Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, corbet@lwn.net, tony.luck@intel.com, gpiccoli@igalia.com, catalin.marinas@arm.com, will@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 12/18] soc: qcom: Register pstore frontend region with minidump Message-ID: <202305161349.7306F11199@keescook> References: <1683133352-10046-1-git-send-email-quic_mojha@quicinc.com> <1683133352-10046-13-git-send-email-quic_mojha@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1683133352-10046-13-git-send-email-quic_mojha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_135036_749798_0C2D7039 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 03, 2023 at 10:32:26PM +0530, Mukesh Ojha wrote: > Since qcom_pstore_minidump driver creates platform device > for qualcomm devices, so it knows the physical addresses > of the frontend region now. Let's register the regions > with qcom_minidump driver. > > Signed-off-by: Mukesh Ojha > [...] > + strlcpy(md_region->name, name, sizeof(md_region->name)); nitpick throughout: Please use strscpy() https://github.com/KSPP/linux/issues/89 -Kees -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel