From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6E39C77B7F for ; Wed, 17 May 2023 08:56:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yciFXLDfpGmJ63LcWkJB/5zeh3O4b+n2uFcp3FvNlRg=; b=tdiaasLi1N2cwoS7dU9u9G57wA xnyNadWEoXmZTKDRi1w+WKim5dc9xbZYQrEMSKcUeLGosfKc9wUJzitY9mgmN2TscpahmK5euw3P9 N7fE0NCkH5imvlPTfOvfDRyZ1cPutKyR72TR9+slaDNWcx6PkRWlavo/dCbx9sywESIbar2lBotwY gHcJyKcSxlwKcSET4tTVqmTVlBwNajBQ2GWVHBK5IhuTFzle6cigBIM8vO1N9BXWJSutOTGpqRQCb zDltwLC9sjnemD9seubpKoDL6vHVMo4GV2hsTxEAuCKCRau6dAgu6EI1ofEf9o4g65SNNFsDavnXu mi46MSNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzCxP-008wsZ-2V; Wed, 17 May 2023 08:56:27 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzCxM-008wrP-0Q for linux-arm-kernel@lists.infradead.org; Wed, 17 May 2023 08:56:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1684313784; x=1715849784; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4S+mksSwEuy7jDabqK76rs9uXWBf27hYxYgzx1zFBEo=; b=QnTbDcRbC43L8FcSaS/nGNOw6ooPNBaN2TjD4Hnb2jVIJh0SjO8oBkTj otF1LAAFfJHYWRv+XzuJU3rJG5wMfZnVkcoF7bXScXh75WIuoOzj/of0X IOAfRcmtG3AsPn3UcmdUasSZNuQ0lHVDJacHodVD+OaHekK3d0/mzYowA UFucocLZeP2NC50ifR+bGKQTbkcBbAHURJSlxbu8oHBQCTYjn2B4v76ZU hGqiUbiKfQX/YlmQyTuC4MCoUTLvkoTHGD+qRjeJHNOHIFWrZahjC7Fpl NlMlYCryU8aDz15Uxu40YefYVOnJ5rgsdTVpZD5/pLcgKjrmAOYYSX0NV w==; X-IronPort-AV: E=Sophos;i="5.99,281,1677567600"; d="asc'?scan'208";a="152498435" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 May 2023 01:56:19 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 17 May 2023 01:56:18 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 17 May 2023 01:56:16 -0700 Date: Wed, 17 May 2023 09:55:55 +0100 From: Conor Dooley To: Subject: Re: [PATCH v4 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml Message-ID: <20230517-railway-babble-df75495cd312@wendy> References: <20230516051836.2511149-1-claudiu.beznea@microchip.com> <20230516051836.2511149-3-claudiu.beznea@microchip.com> <20230516-modulator-reason-1d3a754c6dd7@wendy> <131f3527-8ad8-bdd2-036d-6c8c61f69142@microchip.com> MIME-Version: 1.0 In-Reply-To: <131f3527-8ad8-bdd2-036d-6c8c61f69142@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_015624_565351_32A0CC65 X-CRM114-Status: GOOD ( 21.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8233835830224931919==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8233835830224931919== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cWROMdDqqGTQkPgl" Content-Disposition: inline --cWROMdDqqGTQkPgl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 17, 2023 at 08:48:04AM +0000, Claudiu.Beznea@microchip.com wrot= e: > On 16.05.2023 15:58, Claudiu Beznea - M18063 wrote: > > Hi, Conor, > >=20 > > On 16.05.2023 15:00, Conor Dooley wrote: > >> Hey Claudiu, > >> > >> On Tue, May 16, 2023 at 08:18:33AM +0300, Claudiu Beznea wrote: > >>> Convert Atmel PMC documentation to yaml. Along with it clock names > >>> were adapted according to the current available device trees as > >>> different controller versions accept different clock (some of them > >>> have 3 clocks as input, some has 2 clocks as inputs and some with 2 > >>> input clocks uses different clock names). > >>> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200= -pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.ya= ml > >>> new file mode 100644 > >>> index 000000000000..e5f514bc4bf7 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.ya= ml > >>> @@ -0,0 +1,153 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/clock/atmel,at91rm9200-pmc.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Atmel Power Management Controller (PMC) > >>> + > >>> +maintainers: > >>> + - Claudiu Beznea > >>> + > >>> +description: > >>> + The power management controller optimizes power consumption by con= trolling all > >>> + system and user peripheral clocks. The PMC enables/disables the cl= ock inputs > >>> + to many of the peripherals and to the processor. > >>> + > >>> +properties: > >>> + compatible: > >>> + oneOf: > >>> + - items: > >>> + - const: atmel,at91sam9g20-pmc > >>> + - const: atmel,at91sam9260-pmc > >>> + - const: syscon > >>> + - items: > >>> + - enum: > >>> + - atmel,at91sam9g15-pmc > >>> + - atmel,at91sam9g25-pmc > >>> + - atmel,at91sam9g35-pmc > >>> + - atmel,at91sam9x25-pmc > >>> + - atmel,at91sam9x35-pmc > >>> + - const: atmel,at91sam9x5-pmc > >> Yet another combinations question for you... > >> With this binding the following is not possible: > >> > >> "atmel,at91sam9x5-pmc", "syscon" > >> > >> Is that intended? > >=20 > > No, I've just missed it. Same for the above. I'll have a new round and = fix it. >=20 > Though... shouldn't this have been detected by make dtbs_check? Only if there actually exists a dtb containing compatible =3D "atmel,at91sam9x5-pmc", "syscon"; that is enabled by the config that you are building with. =46rom taking a quick look: git grep "\"atmel,at91sam9x5-pmc\", \"syscon\"" arch/arm/boot/dts/at91sam9g15.dtsi: compatible =3D "atmel,at91sam9g15-pm= c", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9g25.dtsi: compatible =3D "atmel,at91sam9g25-pm= c", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9g35.dtsi: compatible =3D "atmel,at91sam9g35-pm= c", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9x25.dtsi: compatible =3D "atmel,at91sam9x25-pm= c", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9x35.dtsi: compatible =3D "atmel,at91sam9x35-pm= c", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9x5.dtsi: compatible =3D "atmel,at91sam9x5-pmc= ", "syscon"; There's only actually one place where you have this combination & it seems to get overridden by all of the more specific dtsi files that include at91sam9x5.dtsi. Hope that helps, Conor. --cWROMdDqqGTQkPgl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGSWkAAKCRB4tDGHoIJi 0n3gAQCe16U0H1kSoUhYYNlGxAarRvNm6f9LyymQm8xl7FL32wD+Nf5z5eXtVZvs axfaAB+pfK2KqjdQtG6ZEnfYKZ4c/wg= =gglf -----END PGP SIGNATURE----- --cWROMdDqqGTQkPgl-- --===============8233835830224931919== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8233835830224931919==--