From: Xiaoming Ding <xiaoming.ding@mediatek.com>
To: Jens Wiklander <jens.wiklander@linaro.org>,
Sumit Garg <sumit.garg@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<op-tee@lists.trustedfirmware.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Cc: <fei.xu@mediatek.com>, <srv_heupstream@mediatek.com>,
Xiaoming Ding <xiaoming.ding@mediatek.com>
Subject: [PATCH] tee: add FOLL_LONGTERM for CMA case when alloc shm
Date: Wed, 17 May 2023 11:18:56 +0800 [thread overview]
Message-ID: <20230517031856.19660-1-xiaoming.ding@mediatek.com> (raw)
FOLL_LONGTERM will avoid share memory alloc from CMA region,
which may be used in secure playback case.
if part of CMA region taken by share memory for long term usage,
CMA will failed to get whole buffer back.
Signed-off-by: Xiaoming Ding <xiaoming.ding@mediatek.com>
---
drivers/tee/tee_shm.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
index 673cf0359494..ddd3947e2229 100644
--- a/drivers/tee/tee_shm.c
+++ b/drivers/tee/tee_shm.c
@@ -223,6 +223,7 @@ register_shm_helper(struct tee_context *ctx, unsigned long addr,
size_t num_pages;
void *ret;
int rc;
+ u32 page_flag = FOLL_WRITE;
if (!tee_device_get(teedev))
return ERR_PTR(-EINVAL);
@@ -255,9 +256,11 @@ register_shm_helper(struct tee_context *ctx, unsigned long addr,
ret = ERR_PTR(-ENOMEM);
goto err_free_shm;
}
-
+#if IS_ENABLED(CONFIG_CMA)
+ page_flag |= FOLL_LONGTERM;
+#endif
if (flags & TEE_SHM_USER_MAPPED)
- rc = pin_user_pages_fast(start, num_pages, FOLL_WRITE,
+ rc = pin_user_pages_fast(start, num_pages, page_flag,
shm->pages);
else
rc = shm_get_kernel_pages(start, num_pages, shm->pages);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-05-17 3:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 3:18 Xiaoming Ding [this message]
2023-05-17 7:34 ` [PATCH] tee: add FOLL_LONGTERM for CMA case when alloc shm Christoph Hellwig
2023-05-17 7:52 ` Sumit Garg
2023-05-17 8:08 ` Christoph Hellwig
2023-05-17 9:26 ` Sumit Garg
2023-05-17 9:36 ` Christoph Hellwig
2023-05-17 10:19 ` Sumit Garg
2023-05-17 18:23 ` David Hildenbrand
2023-05-18 4:20 ` FOLL_LONGTERM vs FOLL_EPHEMERAL " Christoph Hellwig
2023-05-18 6:08 ` Sumit Garg
2023-05-18 13:56 ` David Hildenbrand
2023-05-23 1:54 ` John Hubbard
2023-05-23 7:25 ` Lorenzo Stoakes
[not found] ` <acc5f89dee4426e8c8953eabc65e932f22dde169.camel@mediatek.com>
2023-06-13 8:48 ` Sumit Garg
[not found] ` <781d993204fbbdf30a6ca495b59b3b0aa7a2e496.camel@mediatek.com>
2023-05-19 10:01 ` David Hildenbrand
2023-05-19 11:03 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517031856.19660-1-xiaoming.ding@mediatek.com \
--to=xiaoming.ding@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=fei.xu@mediatek.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=op-tee@lists.trustedfirmware.org \
--cc=srv_heupstream@mediatek.com \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).