From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDCA5C77B75 for ; Thu, 18 May 2023 01:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cLjyMZLV1PlF7YXdeFNp0Dq+fkLaHONXh3+gH1I3wzg=; b=QawWU6Ss2k/G5D jUyk/2bsgK2dltmWimcl5klKh2jxWkscsMMHlQcPHel3af72l/ATW04Zhl0MuGXSjNbl8n1aGXcHe jOttHEF63EXKB/j88hvQARjRZuwCLkOUphiaYcWL4mRhEgD8sj4DuWANs40d68+E55q1cQ7dHEIag AuxtwKgQ/3cIBoOMLvKmzwI/AHkoaC9H2woIfwYl59KXbmBYibggUjPKsDxamsxC0RwUSXu/wcceA 3gTymqFZOKGMf/A2FR0TC4FD33Cdhh5C+Pwu71GFt6fWq6FHlZjre1J/tvkj0lM5LU7csFQkKSrcU WSr707pPlBF2HH9cA1Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzSNP-00BaSg-22; Thu, 18 May 2023 01:24:19 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzSNL-00BaRP-1x for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 01:24:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684373055; x=1715909055; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fE7YgCkSDZ+nIO0tTZnSypacGkqjCiEQ9o1FV5TUhlM=; b=TzgRjvSCMOVVXCng6POcAUarbrdSP7OBSQ6HMidDuRJpnlJ8Z7D7feVL i5t6nTzkHqohN+5ACAtWfw3rKnPeEdR2VfuLZMQr30/QkaQn8xmFwtXVD ID9s5mXNjXUrBmKQHCge8LwVffF7TaWYYw1yZpwIwZLGp/iOYFv0Y9x9+ wqZE+pBwFr9wRuQNnH3IWWF3MfJuPCI1t6Np+cUMDh99lys6SJzJeVUEw OYPlf+EtZdwvgU88EYFGod7xnxZhJ0pgjlo5L754JLeIn/EGtQW13I0Pc wySyyV/9YtdDhZl0B1G6SPAbqMlsqQKD07Ka7G4Gake0r43cXIsO+POKf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="355113383" X-IronPort-AV: E=Sophos;i="5.99,283,1677571200"; d="scan'208";a="355113383" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 18:24:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="814121371" X-IronPort-AV: E=Sophos;i="5.99,283,1677571200"; d="scan'208";a="814121371" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmsmga002.fm.intel.com with ESMTP; 17 May 2023 18:24:06 -0700 Date: Wed, 17 May 2023 18:27:03 -0700 From: Ricardo Neri To: Sudeep Holla Cc: Radu Rendec , linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Pierre Gondois , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/3] cacheinfo: Add arch specific early level initializer Message-ID: <20230518012703.GA19967@ranerica-svr.sc.intel.com> References: <20230412185759.755408-1-rrendec@redhat.com> <20230412185759.755408-2-rrendec@redhat.com> <20230510191207.GA18514@ranerica-svr.sc.intel.com> <20230515093608.etfprpqn3lmgybe6@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230515093608.etfprpqn3lmgybe6@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_182415_704182_43553EEF X-CRM114-Status: GOOD ( 26.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 15, 2023 at 10:36:08AM +0100, Sudeep Holla wrote: > On Wed, May 10, 2023 at 12:12:07PM -0700, Ricardo Neri wrote: > > Hi, > > > > I had posted a patchset[1] for x86 that initializes > > ci_cacheinfo(cpu)->num_leaves during SMP boot. > > > > It is entirely clear to me if this is just a clean up or a fix to some > issue you faced ? Just wanted to let you know Prateek from AMD has couple > of fixes [2] My first patch is a bug fix. The second patch is clean up that results from fixing the bug in patch 1. > > > This means that early_leaves and a late cache_leaves() are equal but > > per_cpu_cacheinfo(cpu) is never allocated. Currently, x86 does not use > > fetch_cache_info(). > > > > I think that we should check here that per_cpu_cacheinfo() has been allocated to > > take care of the case in which early and late cache leaves remain the same: > > > > - if (cache_leaves(cpu) <= early_leaves) > > + if (cache_leaves(cpu) <= early_leaves && per_cpu_cacheinfo(cpu)) > > > > Otherwise, in v6.4-rc1 + [1] I observe a NULL pointer dereference from > > last_level_cache_is_valid(). > > > > I think this is different issue as Prateek was just observing wrong info > after cpuhotplug operations. But the patches manage the cpumap_populated > state better with the patches. Can you please look at that as weel ? I verified that the patches from Prateek fix a different issue. I was able to reproduce his issue. His patches fixes it. I still see my issue after applying Prateek's patches. > > -- > Regards, > Sudeep > > [2] https://lore.kernel.org/all/20230508084115.1157-1-kprateek.nayak@amd.com Thank you for the suggestion! BR, Ricardo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel