From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD1E3C77B75 for ; Fri, 19 May 2023 19:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xq3332H1yRqrdPhkm4U/RwlAqNZy/eRQ5WKQk/9smAA=; b=FBO9YAJnrej55Xk+NX+Q67kkJs WWJ1K/fP1R6LqwzyCyr6FQQ4ofFMSKNZwQJAZ/tT8K7Md+iKggCNScBzaBrDpfd79GgRYx1jivcZT AQgm1S6E9jL8M5/vA9sZSnixjiHZTyqqrYL4F/yl8ivw8JsG8TSQl1/98f51SCYGIbJfbd5SxOh8t RSv8YOFcRLUrK1xWPVLeAvbW9qrZACHIJFsdWG9ndL5nnMX2LNWK9RLA+bC0ikDt/w1n6QJV0INwm zMkmNV1A+g/w+YtF+cI2zK8wKxy/yasX2kMZTpk7FHXQnNZUTzZUqaRKKAAGWmUooArfiKm16ptsa 5+CP7frw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q05Y2-00H40w-15; Fri, 19 May 2023 19:13:54 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q05Xz-00H40N-1i for linux-arm-kernel@lists.infradead.org; Fri, 19 May 2023 19:13:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3857165A21; Fri, 19 May 2023 19:13:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26A17C433D2; Fri, 19 May 2023 19:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684523629; bh=aRtZRFDPNv2lrbP2lIfnc2TEqimUVJtOgDJ+yrSIzM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ucfD65VKM5HSOr4GO3Gg4K2RHy6M3cnOZ1s8CQVP5XXQvHClZK11nkekfnaS4YIzO o9plZkK1LRsPyjBm2JIr7ByxO/ek+XRNdYGzzRVxP+G8d+cxnqqpgXV9tmU+mTE9uH IilcJYLL3WejjdXLofd5QpNe1b88MN8qST8yoK0+TR7VS4hzW/d66oDxND+LacqwuG AImBQc3Hsa752WLn85yLBtyyh2p1ulsOnE0fsa8MYxhUqRXcfppiR11tYdn+FfDKev ZdF+mKQjKmLEjcJEfqDRItazZqa+WrTFLw3++HQXyxTVw0/1EVWNGDZQuBS/oN4a7r aCmXrzuAH9LQg== Date: Fri, 19 May 2023 20:13:44 +0100 From: Conor Dooley To: Thippeswamy Havalige Cc: krzysztof.kozlowski@linaro.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bhelgaas@google.com, lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org, bharat.kumar.gogada@amd.com, michals@amd.com, nagaradhesh.yeleswarapu@amd.com Subject: Re: [PATCH v3 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge Message-ID: <20230519-decidable-prelude-2f0d58041f02@spud> References: <20230519105901.2399452-1-thippeswamy.havalige@amd.com> <20230519105901.2399452-3-thippeswamy.havalige@amd.com> MIME-Version: 1.0 In-Reply-To: <20230519105901.2399452-3-thippeswamy.havalige@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230519_121351_628992_154684FA X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6940553500255879433==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6940553500255879433== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7bJMJIS2ploL3DA8" Content-Disposition: inline --7bJMJIS2ploL3DA8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 19, 2023 at 04:29:00PM +0530, Thippeswamy Havalige wrote: > Add YAML dtschemas of Xilinx XDMA Soft IP PCIe Root Port Bridge > dt binding. >=20 > Signed-off-by: Thippeswamy Havalige > Signed-off-by: Bharat Kumar Gogada Looks like you might've forgotten a Co-developed-by? > diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml b/= Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml > +properties: > + compatible: > + const: xlnx,xdma-host-3.00 Perhaps not a question for you Thippeswamy, but is there a reason for PCI root ports not having any soc-specific compatibles? Rob (if you see this when you're back)? > + interrupt-controller ; Looks like you didn't see Michal's comment about the extra space. If you resubmit for some other reason, you should fix that in the process :) Cheers, Conor. --7bJMJIS2ploL3DA8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGfKaAAKCRB4tDGHoIJi 0mh8AP4ydIHMh7sRSzRZ6kiE5FV0mOSkS2bEjL2NdWzUiw105QEAmv7RBaLYL3BM Zxji3IjueRdX8XSUwIHtseRmCnO7ZAg= =1KAV -----END PGP SIGNATURE----- --7bJMJIS2ploL3DA8-- --===============6940553500255879433== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6940553500255879433==--