From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91A4AC7EE23 for ; Fri, 19 May 2023 22:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Mpit4g7JeX/zzpqQPIkKGdbDBzLyI4UIv8jg0tzXGk=; b=GjDBCr8YGLeP57 GNfhwxJ5cMzx8ljXh+B9VDq9buQytBImzY9X4UKrbrHijAgl5c1eA27oNtdD36aZt6lsaFpEE09KU vCeyW+3+I172Dx7SMbrIb6zOOxsEQs953DxzEYLsPdRxln+1jEn04N+svidrG30FwR7x9xn/Y+kpG CeJ9Cla/6p+VQ3qYczZyAf/jBRzz30xagVSp+OJLIq0E9aSQvVlJtm4amJto0qY4BHqiifQx1PB8i uokcjjaIYBDmS/YcWrcxdlF6sgTlqcYSmLtcPDTteu1UgO6SPZtLusex5E0KD/Id888lgLT/Vmwbu zlgcMAGNnaECCmsnGC5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q08ZG-00HR6r-2O; Fri, 19 May 2023 22:27:22 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q08ZE-00HR5T-02 for linux-arm-kernel@lists.infradead.org; Fri, 19 May 2023 22:27:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 622CF65B54; Fri, 19 May 2023 22:27:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46EB8C433D2; Fri, 19 May 2023 22:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684535237; bh=3++Hz/H0Ny8iNnJK/HwTOxVy8iKIyU2vlNFkX6To6V8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pMNQ+KnSqIGNuGe3uYk1BjH4DhXTj3M0pEM6ts97Oe75qGoI4/bM7UJ81xFdYa01/ 28QeawEBbtM6Ou0uajuvn0QxJuWgODz3qt/84ZM5TDU5ZMAmrMzNW//56/tPSHI5yR DEgaNOKopY4SR0Zf/rw+81uy8zk+qRItdlE/WesPVVbQRc2OAYOJIqlBsAqNQPMEPo WC2oIi13vw709nUDVb48rqMMBjWwfojI1SgsVv3Xg0ManDOdMtIinOCKdXeHoYuiS9 1ifR2XvFgM3XuVICy2X5RVtCXDlD21fS50Q5udLIhvdsGkyLDtEWTYInCEx3MTkyos YntJnPPLrqioA== Date: Fri, 19 May 2023 15:27:15 -0700 From: Jakub Kicinski To: Min-Hua Chen Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Simon Horman , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] net: stmmac: compare p->des0 and p->des1 with __le32 type values Message-ID: <20230519152715.7d1c3a49@kernel.org> In-Reply-To: <20230519115030.74493-1-minhuadotchen@gmail.com> References: <20230519115030.74493-1-minhuadotchen@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230519_152720_115085_940646C7 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 19 May 2023 19:50:28 +0800 Min-Hua Chen wrote: > - if ((p->des0 == 0xffffffff) && (p->des1 == 0xffffffff)) > + if (p->des0 == cpu_to_le32(0xffffffff) && > + p->des1 == cpu_to_le32(0xffffffff)) Can you try to fix the sparse tool instead? I believe it already ignores such errors for the constant of 0, maybe it can be taught to ignore all "isomorphic" values? By "isomorphic" I mean that 0xffffffff == cpu_to_le32(0xffffffff) so there's no point complaining. -- pw-bot: reject _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel