Re: [PATCH v4 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries

From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, marex@denx.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH v4 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
Date: Sat, 20 May 2023 11:15:09 +0100	[thread overview]
Message-ID: <20230520-iphone-outreach-14f46c57b7cd@spud> (raw)
In-Reply-To: <20230519125236.352050-1-festevam@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1683 bytes --]

On Fri, May 19, 2023 at 09:52:33AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add
> some logic to reflect that.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Whoops, didn't see this patch yesterday..

> ---
> Changes since v3:
> - None.
> 
>  .../bindings/display/bridge/fsl,ldb.yaml      | 28 +++++++++++++++++--
>  1 file changed, 25 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> index 07388bf2b90d..cd63f9ef9484 100644
> --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> @@ -28,12 +28,12 @@ properties:
>      const: ldb
>  
>    reg:
> +    minItems: 1
>      maxItems: 2
>  
>    reg-names:
> -    items:
> -      - const: ldb
> -      - const: lvds
> +    minItems: 1
> +    maxItems: 2
>  
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports
> @@ -74,6 +74,28 @@ allOf:
>            properties:
>              port@2: false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx6sx-ldb

Why not const: for the single item?
Trying to avoid churn when you add your next one?

> +    then:
> +      properties:
> +        reg:
> +          maxItems: 1
> +        reg-names:
> +          items:
> +            - const: ldb

Again, can drop the items: for const: for the single item, no?

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel