From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 751D5C77B75 for ; Tue, 23 May 2023 15:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d/3ICBN271Yd+3LRIelvo+XYuymKHi0iUZ12HUhtwoY=; b=MLOe0ebkiURVfO wOKzIDLbAjM308HQhMxCX3xdyv2X/TR9WBDADeGrhN0tbBZCjioYsXw5skBvuM0xsNTizBnYcrdKm lT5dvHj3/inB5GS9KRragehnlDmUaltWUCQIfltqmWK6NAJOc+KnbZDbo+Z0fzOcxuHiCqE01K5LX Jo6ZpTUT0Mb0rLZFw/tj18bpc8B7vRPOQh9Kj5rYAkgp2aZfEIJHONevE4PtjfgsrtYZ+acqfWP9V 7x2063SPGDVSR97OIK88LvXETgytovlAaCR4X8LZIhL7pPQDlZz/jTLb+p4UteJxCq4j2ELaWELOC snFdHo/1mLvWUxwERcgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1Tjy-00AbXw-1f; Tue, 23 May 2023 15:15:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1Tjv-00AbWi-2w for linux-arm-kernel@lists.infradead.org; Tue, 23 May 2023 15:15:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5474D139F; Tue, 23 May 2023 08:16:36 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03F0D3F840; Tue, 23 May 2023 08:15:48 -0700 (PDT) Date: Tue, 23 May 2023 16:15:46 +0100 From: Sudeep Holla To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, suzuki.poulose@arm.com, Ganapatrao Kulkarni , Steve Clevenger , Rob Herring , Frank Rowand , Russell King , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH V4 4/6] coresight: etm4x: Change etm4_platform_driver driver for MMIO devices Message-ID: <20230523151546.bpvrrqvp2xho2i5w@bogus> References: <20230523044553.1525048-1-anshuman.khandual@arm.com> <20230523044553.1525048-5-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230523044553.1525048-5-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230523_081556_015041_52FA155B X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 23, 2023 at 10:15:51AM +0530, Anshuman Khandual wrote: > Add support for handling MMIO based devices via platform driver. We need to > make sure that : > > 1) The APB clock, if present is enabled at probe and via runtime_pm ops Was mainly interested in the above to ensure it works smoothly once migrate to this with ACPI. The changes look good to me. So, Acked-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel