From: Mike Rapoport <rppt@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ardb@kernel.org>, Marc Zyngier <maz@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Justin M . Forbes" <jforbes@fedoraproject.org>
Subject: Re: [PATCH] arm64: Remove the ARCH_FORCE_MAX_ORDER config input prompt
Date: Tue, 23 May 2023 19:12:21 +0300 [thread overview]
Message-ID: <20230523161221.GI4967@kernel.org> (raw)
In-Reply-To: <20230519171440.1941213-1-catalin.marinas@arm.com>
On Fri, May 19, 2023 at 06:14:40PM +0100, Catalin Marinas wrote:
> Commit 34affcd7577a ("arm64: drop ranges in definition of
> ARCH_FORCE_MAX_ORDER") dropped the ranges from the config entry and
> introduced an EXPERT condition on the input prompt instead.
>
> However, starting with defconfig (ARCH_FORCE_MAX_ORDER of 10) and
> setting ARM64_64K_PAGES together with EXPERT leaves MAX_ORDER 10 which
> fails to build in this configuration.
>
> Drop the input prompt for ARCH_FORCE_MAX_ORDER completely so that it's
> no longer configurable. People requiring a higher MAX_ORDER should send
> a patch changing the default, together with proper justification.
>
> Fixes: 34affcd7577a ("arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER")
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Marc Zyngier <maz@kernel.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Justin M. Forbes <jforbes@fedoraproject.org>
Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> arch/arm64/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index b1201d25a8a4..343e1e1cae10 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1516,7 +1516,7 @@ config XEN
> # 16K | 27 | 14 | 13 | 11 |
> # 64K | 29 | 16 | 13 | 13 |
> config ARCH_FORCE_MAX_ORDER
> - int "Order of maximal physically contiguous allocations" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES)
> + int
> default "13" if ARM64_64K_PAGES
> default "11" if ARM64_16K_PAGES
> default "10"
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-23 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 17:14 [PATCH] arm64: Remove the ARCH_FORCE_MAX_ORDER config input prompt Catalin Marinas
2023-05-23 16:12 ` Mike Rapoport [this message]
2023-05-24 6:20 ` Anshuman Khandual
2023-05-29 13:41 ` Marc Zyngier
2023-06-02 12:33 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523161221.GI4967@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jforbes@fedoraproject.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).