From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC358C7EE2D for ; Tue, 23 May 2023 16:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tUKRDaE70q5FTmIHug26PDA3JLUqQWPq4FxDhc4xE5c=; b=fVaHqt4xQeB5gl 2aReLTd10S7jua94ppUQIasFs3pSi0R5Zwhf2GtDxL3kLcCkkXwv65myBYkrkFluIqeb+9N6VCvB/ 84CwsDJHhN8/SSfmcYJyuANnqRLMimp2UKnDV/oD+ZgR2PqFtJcDe4iCetL22lMdIAciyNmkKXQg3 lMMFnhG0NrENClfPwc2Yxrkhegvf9oNjr25pZNk1wevzbU9RY89j6bAlJaAbJgQFPrgCq0dDfa7Ql 4Z4Kuifl8/cmGGagy+qgkCzmSYbTz3W9/PRgxtkRH0hhYK+ULezSkpnVWscbtwU8ydmELuej8UVAF nx/9fXVv3dT4QfXvruMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1Ucu-00Al4g-34; Tue, 23 May 2023 16:12:44 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1Ucs-00Al4K-1M for linux-arm-kernel@lists.infradead.org; Tue, 23 May 2023 16:12:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C17EC63376; Tue, 23 May 2023 16:12:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 753A3C433D2; Tue, 23 May 2023 16:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684858361; bh=mTS/A2YuKoQ5vi0zzIYnG7XYt9skEPt+L+jnbpRrzZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hPZeFwa9UFKUdT5fwli0Ip2WHIT5+NU5W5ltrshBEFAqvSfrIKpmOkDnb7VKc1US5 LhHUfKuBaw9Fj82w3iX7I7zH/Uu56RCHpEIEVOHpeiKCAAGfKoWS95rAjVKUMHpeLc urHfFuW+rLAlxM1OcxPlFz3zJwvyBnIiUo36aQZeA7nVhS9n+/zmZ3xD7jRbCAzyPn YuthYjx1UAWxBgxcPth42UjgvgL7ngrTsDmGbRAOpymk3pE7l8NEEkNAr5zmbrox0Z Y5Fc8T2rQjMYeJ2vfcLjz/afwoz5G24eO5N2n1WgG0MqdGGavGQW6vhB6PpP9BPeVT m3TvPdoruzW3w== Date: Tue, 23 May 2023 19:12:21 +0300 From: Mike Rapoport To: Catalin Marinas Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Marc Zyngier , Andrew Morton , "Justin M . Forbes" Subject: Re: [PATCH] arm64: Remove the ARCH_FORCE_MAX_ORDER config input prompt Message-ID: <20230523161221.GI4967@kernel.org> References: <20230519171440.1941213-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230519171440.1941213-1-catalin.marinas@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230523_091242_506254_AF781F3B X-CRM114-Status: GOOD ( 21.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 19, 2023 at 06:14:40PM +0100, Catalin Marinas wrote: > Commit 34affcd7577a ("arm64: drop ranges in definition of > ARCH_FORCE_MAX_ORDER") dropped the ranges from the config entry and > introduced an EXPERT condition on the input prompt instead. > > However, starting with defconfig (ARCH_FORCE_MAX_ORDER of 10) and > setting ARM64_64K_PAGES together with EXPERT leaves MAX_ORDER 10 which > fails to build in this configuration. > > Drop the input prompt for ARCH_FORCE_MAX_ORDER completely so that it's > no longer configurable. People requiring a higher MAX_ORDER should send > a patch changing the default, together with proper justification. > > Fixes: 34affcd7577a ("arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER") > Signed-off-by: Catalin Marinas > Reported-by: Marc Zyngier > Cc: Will Deacon > Cc: Mike Rapoport > Cc: Andrew Morton > Cc: Justin M. Forbes Acked-by: Mike Rapoport (IBM) > --- > arch/arm64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index b1201d25a8a4..343e1e1cae10 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1516,7 +1516,7 @@ config XEN > # 16K | 27 | 14 | 13 | 11 | > # 64K | 29 | 16 | 13 | 13 | > config ARCH_FORCE_MAX_ORDER > - int "Order of maximal physically contiguous allocations" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES) > + int > default "13" if ARM64_64K_PAGES > default "11" if ARM64_16K_PAGES > default "10" -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel