From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BBE7C77B7C for ; Wed, 24 May 2023 19:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YFdDAC3cCFopHBwKgcBCvTSTj2roRTy24gITpv7yxdM=; b=gQyL2agpQaPTWh3HCpiqH/vdsZ dNzKGksgulmeJuHlA7Sc7WndP+JbCuUypI5r7BbjanazsfUnKlKrt+1w12e8jLsD2PFJV8zs/bvPz yD8Vxp6RAyigs6/eNUUZc03+zISz8c+ov6aMQuOFN2WNEwrNW6K8dZCD6e4vV4xcaYtUOo8FoOq0j VnRKQU5+KaDDBEHZb/ymDtUX8wFm4qsqNRpk7RI8taxdroSKy8qibyYlVsKPje6xg1LcdnTNHmbX9 rqcleEmAjXiaDz0Mnau6eSU+QLcL5WBw0W6l1N5mitrna2u7hezj0QJGxt29Cg5jNgbjUjLvjDMZe YGRpi3dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1uNk-00EVMS-22; Wed, 24 May 2023 19:42:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1uNh-00EVM0-0h; Wed, 24 May 2023 19:42:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4612E6405B; Wed, 24 May 2023 19:42:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3685AC433EF; Wed, 24 May 2023 19:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684957362; bh=yZ++4rmAz/binbPZ2raZ7oKQBeGS4KnGAb2gGZ8Sg9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GnpAesAX1Mplqldy+UcyxvjJnee2n29HLmjvyzYkREAddxM1xqMyZHkEm3L1R65gx JkENY78Gjqxwr2sOUI2GcM9NeMaUb1urWDGiIVayse7u/RxpuUSy/hAuTrUL6urxM/ 6OPpwlIZtAyL2IGwXWWTLUuPJRqpAjCnbKAXT04tQWe5AlapwwpDXDHZPOExWjjyhJ Vb1n4nSEgV2CrbBLeYVpLMP3m9j8ABzHhKNRnuV5X/2w0PSecXvAM4DfCYMWTHhAOj 0nIWnDQZJPDN0HOAqFjl0bPjbMBkuNcHAGeVbly/rKew214e3daRAZ0z400dW995YG Ek+4YxLXKUHeQ== Date: Wed, 24 May 2023 20:42:36 +0100 From: Conor Dooley To: Sascha Hauer Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , kernel@pengutronix.de, Michael Riesch , Robin Murphy , Vincent Legoll , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Subject: Re: [PATCH v5 21/25] dt-bindings: devfreq: event: rockchip,dfi: Add rk3568 support Message-ID: <20230524-cleft-dial-80d6af1444b1@spud> References: <20230524083153.2046084-1-s.hauer@pengutronix.de> <20230524083153.2046084-22-s.hauer@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20230524083153.2046084-22-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230524_124245_353637_96E83EB4 X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0285382565843181858==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0285382565843181858== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e2+WROMaYECLcWsp" Content-Disposition: inline --e2+WROMaYECLcWsp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 24, 2023 at 10:31:49AM +0200, Sascha Hauer wrote: > This adds the rockchip,rk3568-dfi compatible to the binding. Make clocks > optional for this SoC as the RK3568 doesn't have a kernel controllable > PCLK. >=20 > Signed-off-by: Sascha Hauer This one looks fine to me, Reviewed-by: Conor Dooley Thanks, Conor. > --- > .../bindings/devfreq/event/rockchip,dfi.yaml | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi= =2Eyaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > index 7a82f6ae0701e..e8b64494ee8bd 100644 > --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > @@ -13,6 +13,7 @@ properties: > compatible: > enum: > - rockchip,rk3399-dfi > + - rockchip,rk3568-dfi > =20 > clocks: > maxItems: 1 > @@ -34,11 +35,21 @@ properties: > =20 > required: > - compatible > - - clocks > - - clock-names > - interrupts > - reg > =20 > +if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3399-dfi > + > +then: > + required: > + - clocks > + - clock-names > + > additionalProperties: false > =20 > examples: > --=20 > 2.39.2 >=20 --e2+WROMaYECLcWsp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZG5orAAKCRB4tDGHoIJi 0ucHAP9IMyFG6czvO674KoDL2bxtyJclg3iXK5ERZj5OwBBCgwEAjKj4CDc0G7VZ 3Sw9LBW8vUtkMyeqs1or9GnhhepHAg0= =eVHC -----END PGP SIGNATURE----- --e2+WROMaYECLcWsp-- --===============0285382565843181858== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0285382565843181858==--