From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA171C77B73 for ; Wed, 24 May 2023 07:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p75B83niZP5pubATouHuwMQmN1JgkFeUxLomAsullZU=; b=t7ZIT+oHnUBWyK o9Vt2nBEHNiI+trbDxBEcJTbg6bgAiuxLcM8DXqOmZovKqg0nT2n0Hiwtboz1Uw9smZnp4Wn6xq1X roLYMcmJ2ObIwz/TeuJH08IWwhPFPHTMbrhJh8s1Zn3DBNC9e4JwWRFVpv4wsS6I4YVTjzem7xzl5 GG061yYHOLarVJ8zLM8hFeAT2IniGsBGq1KQO1syIw9YP+f7wuccwY8zayCb2gTNrmVCBDCdbh2bB p4O22amTpTB8OoY4KxI0zPUqXM+TMbpNymbZxc8x53GRrScj3JqYOhAf068s1BAUdLD0pdumZeMzk NntjgwBM2QHle5GziSzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1itI-00CbNK-2l; Wed, 24 May 2023 07:26:36 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1itF-00CbMW-2k for linux-arm-kernel@lists.infradead.org; Wed, 24 May 2023 07:26:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1684913193; x=1716449193; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rQ0DuZshKAbz/udXXhLXGtUBznxtKAoyeYG8wTrC7VQ=; b=cxvhfRjiNeLIogMvGSXxLm9QeVona9M3iEYIrj2Td2bjDjPc95fQ6h8v FpcD9mm2PZ+zWlDdvJJxFrxypRjzcGAuyp+6CbTYDft9+UfFBS6ifZXYE zP0LG0ohMIIugarDYJtMnO/r4khpKnWnusdSVHJRPkysd9G8Hb3xXkyCg HqrG8U5msS1V9Q4WPDIvcFd9tI2FDFCgUOW3UwfRok1xcphs7Fw6s7zMl K26N70wqR1DR5cJl0x5r4t/OTWXAkZBbUjwRSknDt1gbnOy7J3iiSojXG mRjNJmZgQUGM4Swe2C4z/QNKGUIZEon8vVPcL1vzuN5V/MGnoVEkrWEbi Q==; X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="217006483" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 May 2023 00:26:25 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 24 May 2023 00:26:20 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Wed, 24 May 2023 00:26:20 -0700 Date: Wed, 24 May 2023 09:26:19 +0200 From: Horatiu Vultur To: "Russell King (Oracle)" CC: Andrew Lunn , Heiner Kallweit , Daniel Machon , "David S. Miller" , Eric Dumazet , Florian Fainelli , Ioana Ciornei , Jakub Kicinski , Lars Povlsen , , Madalin Bucur , Marcin Wojtas , Michal Simek , , Paolo Abeni , Radhey Shyam Pandey , Sean Anderson , Steen Hegelund , Taras Chornyi , Thomas Petazzoni , , Vladimir Oltean Subject: Re: [PATCH RFC 0/9] Add and use helper for PCS negotiation modes Message-ID: <20230524072619.dnzfy3lmgobqmu2k@soft-dev3-1> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230524_002633_981076_9BAEE112 X-CRM114-Status: GOOD ( 23.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 05/23/2023 16:54, Russell King (Oracle) wrote: Hi Russell, I have tried this series on lan966x and it seems to be working fine. There was a small issue applying the patch 3, as the function 'phylink_resolve_c73' doesn't exist yet. > > Hi, > > Earlier this month, I proposed a helper for deciding whether a PCS > should use inband negotiation modes or not. There was some discussion > around this topic, and I believe there was no disagreement about > providing the helper. > > The discussion can be found at: > > https://lore.kernel.org/r/ZGIkGmyL8yL1q1zp@shell.armlinux.org.uk > > This series adds that helper, and modifies most code to use it. I have > a couple of further patches that hoist this function out of every PCS > driver and into phylink's new phylink_pcs_config() function that I've > posted separately, and drop the "mode" argument to the pcs_config() > method, instead passing the result of phylink_pcs_neg_mode(). > > I haven't included those because this series doesn't update everything > in net-next, but for RFC purposes, I think this is good enough to get > a few whether people are generally happy or not. > > Note that this helper is only about modes that affect the PCS such as > the SGMII family and 802.3z types, not amount negotiation that happens > in order to select a PCS (e.g. for backplanes.) > > drivers/net/dsa/qca/qca8k-8xxx.c | 13 ++-- > drivers/net/ethernet/freescale/fman/fman_dtsec.c | 7 +- > drivers/net/ethernet/marvell/mvneta.c | 5 +- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 +- > .../net/ethernet/marvell/prestera/prestera_main.c | 10 ++- > .../ethernet/microchip/lan966x/lan966x_phylink.c | 8 ++- > .../net/ethernet/microchip/sparx5/sparx5_phylink.c | 8 ++- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 5 +- > drivers/net/pcs/pcs-lynx.c | 18 +++-- > drivers/net/phy/phylink.c | 14 ++-- > include/linux/phylink.h | 81 +++++++++++++++++++++- > 11 files changed, 136 insertions(+), 37 deletions(-) > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel