linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells
@ 2023-05-24 13:10 Fabio Estevam
  2023-05-24 13:10 ` [PATCH 2/4] ARM: dts: imx7d-smegw01: Pass 'gpr' to the pinctrl groups Fabio Estevam
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-05-24 13:10 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Remove the unneeded #address-cells/#size-cells from sram@0 to fix
the following 'make CHECK_DTBS=y imx7d-smegw01.dtb' warning:

sram@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
From schema: Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/imx7d-smegw01.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx7d-smegw01.dts b/arch/arm/boot/dts/imx7d-smegw01.dts
index c0f00f5db11e..76bbc2ab126e 100644
--- a/arch/arm/boot/dts/imx7d-smegw01.dts
+++ b/arch/arm/boot/dts/imx7d-smegw01.dts
@@ -97,8 +97,6 @@ &ecspi1 {
 	sram@0 {
 		compatible = "microchip,48l640";
 		reg = <0>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 		spi-max-frequency = <16000000>;
 	};
 };
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/4] ARM: dts: imx7d-smegw01: Pass 'gpr' to the pinctrl groups
  2023-05-24 13:10 [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells Fabio Estevam
@ 2023-05-24 13:10 ` Fabio Estevam
  2023-05-24 13:10 ` [PATCH 3/4] ARM: dts: imx7d-smegw01: Use pinctrl-0 for pinctrl_rfkill Fabio Estevam
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-05-24 13:10 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Pass 'gpr' to the pinctrl groups to fix the following
'make CHECK_DTBS=y imx7d-smegw01.dtb' warning:

pinctrl@30330000: 'rfkillrp', 'usbotg1', 'usbotg1-pwr', 'usbotg1-pwr-gpio' do not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/imx7d-smegw01.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx7d-smegw01.dts b/arch/arm/boot/dts/imx7d-smegw01.dts
index 76bbc2ab126e..829a3cbf8ad3 100644
--- a/arch/arm/boot/dts/imx7d-smegw01.dts
+++ b/arch/arm/boot/dts/imx7d-smegw01.dts
@@ -327,7 +327,7 @@ MX7D_PAD_SAI2_RX_DATA__GPIO6_IO21	0x17059
 		>;
 	};
 
-	pinctrl_rfkill: rfkillrp {
+	pinctrl_rfkill: rfkillgrp {
 		fsl,pins = <
 			MX7D_PAD_EPDC_DATA11__GPIO2_IO11	0x17059
 		>;
@@ -353,19 +353,19 @@ MX7D_PAD_UART3_RX_DATA__UART3_DCE_RX	0x74
 		>;
 	};
 
-	pinctrl_usbotg1_lpsr: usbotg1 {
+	pinctrl_usbotg1_lpsr: usbotg1grp {
 		fsl,pins = <
 			MX7D_PAD_LPSR_GPIO1_IO04__USB_OTG1_OC	0x04
 		>;
 	};
 
-	pinctrl_usbotg1_pwr: usbotg1-pwr {
+	pinctrl_usbotg1_pwr: usbotg1-pwrgrp {
 		fsl,pins = <
 			MX7D_PAD_LPSR_GPIO1_IO05__USB_OTG1_PWR	0x04
 		>;
 	};
 
-	pinctrl_usbotg1_pwr_gpio: usbotg1-pwr-gpio {
+	pinctrl_usbotg1_pwr_gpio: usbotg1-pwr-gpiogrp {
 		fsl,pins = <
 			MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5	0x04
 		>;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/4] ARM: dts: imx7d-smegw01: Use pinctrl-0 for pinctrl_rfkill
  2023-05-24 13:10 [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells Fabio Estevam
  2023-05-24 13:10 ` [PATCH 2/4] ARM: dts: imx7d-smegw01: Pass 'gpr' to the pinctrl groups Fabio Estevam
@ 2023-05-24 13:10 ` Fabio Estevam
  2023-05-24 13:10 ` [PATCH 4/4] ARM: dts: imx7d-smegw01: Pass Ethernet aliases Fabio Estevam
  2023-05-27 13:07 ` [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-05-24 13:10 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Use pinctrl-0 for pinctrl_rfkill to fix the following
'make CHECK_DTBS=y imx7d-smegw01.dtb' warning:

regulator-wlan-rfkill: 'pinctrl-0' is a dependency of 'pinctrl-names'

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/imx7d-smegw01.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7d-smegw01.dts b/arch/arm/boot/dts/imx7d-smegw01.dts
index 829a3cbf8ad3..7ec830e4ee05 100644
--- a/arch/arm/boot/dts/imx7d-smegw01.dts
+++ b/arch/arm/boot/dts/imx7d-smegw01.dts
@@ -67,7 +67,7 @@ reg_wifi: regulator-wifi {
 	reg_wlan_rfkill: regulator-wlan-rfkill {
 		compatible = "regulator-fixed";
 		pinctrl-names = "default";
-		pinctrl-2 = <&pinctrl_rfkill>;
+		pinctrl-0 = <&pinctrl_rfkill>;
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		regulator-name = "wlan_rfkill";
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 4/4] ARM: dts: imx7d-smegw01: Pass Ethernet aliases
  2023-05-24 13:10 [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells Fabio Estevam
  2023-05-24 13:10 ` [PATCH 2/4] ARM: dts: imx7d-smegw01: Pass 'gpr' to the pinctrl groups Fabio Estevam
  2023-05-24 13:10 ` [PATCH 3/4] ARM: dts: imx7d-smegw01: Use pinctrl-0 for pinctrl_rfkill Fabio Estevam
@ 2023-05-24 13:10 ` Fabio Estevam
  2023-05-27 13:07 ` [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-05-24 13:10 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Pass Ethernet aliases, so that the bootloader can properly pass MAC address
to Linux.

This fixes the problem of getting a random MAC address for eth1 in Linux.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/imx7d-smegw01.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/imx7d-smegw01.dts b/arch/arm/boot/dts/imx7d-smegw01.dts
index 7ec830e4ee05..85b97b5f64e7 100644
--- a/arch/arm/boot/dts/imx7d-smegw01.dts
+++ b/arch/arm/boot/dts/imx7d-smegw01.dts
@@ -13,6 +13,8 @@ / {
 	compatible = "storopack,imx7d-smegw01", "fsl,imx7d";
 
 	aliases {
+		ethernet0 = &fec1;
+		ethernet1 = &fec2;
 		mmc0 = &usdhc1;
 		mmc1 = &usdhc3;
 		mmc2 = &usdhc2;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells
  2023-05-24 13:10 [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells Fabio Estevam
                   ` (2 preceding siblings ...)
  2023-05-24 13:10 ` [PATCH 4/4] ARM: dts: imx7d-smegw01: Pass Ethernet aliases Fabio Estevam
@ 2023-05-27 13:07 ` Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2023-05-27 13:07 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

On Wed, May 24, 2023 at 10:10:05AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Remove the unneeded #address-cells/#size-cells from sram@0 to fix
> the following 'make CHECK_DTBS=y imx7d-smegw01.dtb' warning:
> 
> sram@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
> From schema: Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied all, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-05-27 13:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-24 13:10 [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells Fabio Estevam
2023-05-24 13:10 ` [PATCH 2/4] ARM: dts: imx7d-smegw01: Pass 'gpr' to the pinctrl groups Fabio Estevam
2023-05-24 13:10 ` [PATCH 3/4] ARM: dts: imx7d-smegw01: Use pinctrl-0 for pinctrl_rfkill Fabio Estevam
2023-05-24 13:10 ` [PATCH 4/4] ARM: dts: imx7d-smegw01: Pass Ethernet aliases Fabio Estevam
2023-05-27 13:07 ` [PATCH 1/4] ARM: dts: imx7d-smegw01: Remove unneeded #address-cells/#size-cells Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).