Re: [PATCH net-next 16/30] net: dsa: mt7530: move lowering port 5 RGMII driving to mt7530_setup()

Vladimir Oltean
2023-06-04T07:15:21Z

On Sun, Jun 04, 2023 at 10:05:44AM +0300, Arınç ÜNAL wrote:
> It wouldn't. I'll drop this patch, thanks. For reference, PMCR_TX_EN (bit
> 14) for port 5 is also set in the case of PHY muxing with this code on
> mt7530_setup_port5() which doesn't use phylink.
>
> /* Setup the MAC by default for the cpu port */
> mt7530_write(priv, MT7530_PMCR_P(5), 0x56300);
>
> 0x56300 = 0101 0110 0011 0000 0000
>
> Maybe I should make a patch to use the definitions on mt7530.h for this?
>
> Arınç

Yes, I don't believe magic numbers make things particularly obvious for
other driver writers, they should be avoided if possible.