From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5E61C77B73 for ; Wed, 24 May 2023 14:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IDSmFRctmlxxsObwOIOeqAtj00BhHew7sFqDAGV+cvo=; b=OCp9vSKPUy44rD nurdaJgIedYe1aUCBuo1AuFV1iUFNqHiUqji36FR4OT8xpMRY0vu/kcolk5Zihunc5fBI/WpdOrp9 vXK07+18vnRaajbgqBG6qPs9kKnU/yzHdNUTPZ/vymqKgL7WPHDW9K9GcP/Imkp7sqJoYSkwsYbw8 GCFE8f7lEoDphIWVgAtVf/PKimuQ4pJIlkpKOyQ5SWVuiv7RbSNs2yYGwlqfnhqXIIik+dZ1yTGyy gL8hjSvPhJZrImLguiQsbhrRZeCyYHwbe1s2B+gWjYKHedpZ5yScTDNJoeagrvJKiaqEQwFrMgy/C GT2eHdGRFkpWnQPA5XXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1poI-00DjjR-0N; Wed, 24 May 2023 14:49:54 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1poF-00DjiY-3A; Wed, 24 May 2023 14:49:53 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-96f53c06babso188036466b.3; Wed, 24 May 2023 07:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684939790; x=1687531790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FyedHscGEFlAyTcL2YX1NQlnWA/wiw8R69Wx/wJ/hdc=; b=RV82gdRnlL16Wu65qUhDbXspGrdeIIJWl7xoa/6zOSti527MJevjRimiCUzTPziFZO LXQF1ZDTV/3/zcamdtRZz8ZjTaCRwsRV9S4pFZ5uklNReyQaGjFVv3TJgM4bAWXjYWza 5scM0fGoMJ8KHYC5sOXZKcIu/O7oNwIojF7xr6ksdH8Y/wsUh0ZyAQ63d0autUHNZ+2u twl1rjWsIe9uU1TwygoWEQUSMnIkZxXuGB36/3ZQrCHItcfEfFNz/Ks7G+2HWFII+w15 iVvlxK9KgFPbc/ltVEXrdiH94N3tysE4hkZxe5PjKCfJbv7tdp0ZDa1jmwaj+2d0e82d h0Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684939790; x=1687531790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FyedHscGEFlAyTcL2YX1NQlnWA/wiw8R69Wx/wJ/hdc=; b=j1CZTV5e/mXWXyJJW7VKxcoeXP0LWIjGUsl2wpelK1NopSA9ZEIMehtQbU5CEX349p 8wXz3+ajEV2ZnmvEkVMo/W+Xjcfe8qvhLEfRvcnmZcxhvOtNfuYs913ApZMitQv7JWM3 VLmv/+mVshaPviBjOLcA+jCYujgLApp+HWZfoRk5qUOfSyLdr4mI1HLFoxVFYbKorg0O mdXY5oCfuLC6dVLf8hMsX7A1UyPiE4g63twRXyYIfF1NIZ5ed+6Gb6oPjZQtzPaCnflq /tmOm65WzhYvxaBUnPfWJRlS8DvODYLm+JCeNwAbTtj/w4YFNnaM8wENQ8aVI3vv+muo GmiA== X-Gm-Message-State: AC+VfDzk6d/iF0OSsOCWWbMKk7AQp0aFB/e3o81gFZD/ggCqewNNfUNH 5NWsmCFXg8g7YzqQMO/v1H0= X-Google-Smtp-Source: ACHHUZ5f5jpmlXfXl69c8NP7gio6BtFCBwM5CIosxzVdgEMVR+GMD/bINdQsFaYe/W+T8c0ISQL5aw== X-Received: by 2002:a17:907:9308:b0:969:fc68:fa9a with SMTP id bu8-20020a170907930800b00969fc68fa9amr16755972ejc.40.1684939790273; Wed, 24 May 2023 07:49:50 -0700 (PDT) Received: from skbuf ([188.27.184.189]) by smtp.gmail.com with ESMTPSA id z27-20020a17090674db00b0096efa536229sm6055956ejl.149.2023.05.24.07.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 07:49:50 -0700 (PDT) Date: Wed, 24 May 2023 17:49:47 +0300 From: Vladimir Oltean To: arinc9.unal@gmail.com Cc: Sean Wang , Landen Chao , DENG Qingfang , Daniel Golle , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Richard van Schagen , Richard van Schagen , Frank Wunderlich , Bartel Eerdekens , erkin.bozoglu@xeront.com, mithat.guner@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 04/30] net: dsa: mt7530: improve comments regarding port 5 and 6 Message-ID: <20230524144947.tdpwdvcssjkr7efu@skbuf> References: <20230522121532.86610-1-arinc.unal@arinc9.com> <20230522121532.86610-5-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230522121532.86610-5-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230524_074952_015591_B8AB4CC8 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 22, 2023 at 03:15:06PM +0300, arinc9.unal@gmail.com wrote: > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 024b853f9558..b28d66a7c0b2 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2499,7 +2499,9 @@ static void mt7530_mac_port_get_caps(struct dsa_switch *ds, int port, > config->supported_interfaces); > break; > > - case 5: /* 2nd cpu port with phy of port 0 or 4 / external phy */ > + case 5: /* Port 5 which can be used as a CPU port supports rgmii with > + * delays, mii, and gmii. > + */ Please put the comments on dedicated lines: /* Port X can be used as ... */ case X: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel