From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2376C77B7A for ; Thu, 25 May 2023 12:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GLtEBNrXUH/0bM2oLaU4lZHA8LSYYUxxLuQ+2D6joAg=; b=yluLd9jKKD3fNo mbpdhvkuO91PGEfoSLYR+oUK+Jh9SUbARSzp1jwrLiuaHeUuNr9O8a9bdy7dXxhP3Npcn1KBOtbdX 1MjODByLWud0MVrbenncyCstgzidcN9EsPRqI9pQKZiipaLW2rdG+93rsHrUbIuOkT4yNaBxMn52m 4IWcUUuvO3K6lKQMCwpoTFzyyKgcPadjCkeYtw+lisEp2oSkD0e8BUjMxn1tDoHxBhqgvmCu3lhqz 3PB71o3SB62AoeMmQwnm5SDE3e6LoTwpR0d339bGFjbgoi2+FGuDttGSPbB0XrTAf/jkjLqnj6fL/ P5pPBsOob4QpfgOxWzHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2AKE-00GdwI-1h; Thu, 25 May 2023 12:44:14 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2AKA-00Gdv1-22 for linux-arm-kernel@lists.infradead.org; Thu, 25 May 2023 12:44:12 +0000 X-GND-Sasl: maxime.chevallier@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685018644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=feQW98atuVGJR2g0z3VlLS9I5fF0OgwIq8sXEMfFC28=; b=d2q9GAMDrDVfcZSPsOhWMuyyoXiCcYlXwPhHX3iLR80pY8cnEsNDVhuflsLM1uEys7WC3Q iEk/QVY+mnBmjDGSB3MW4JvhtiMokHVMM04OkEC1kzROmDIBxrLJlP+PlFHiSYfCN11lP3 2DZhxM4AtrVs7tWNVv/SHhSJzPEX6xUHfNdmPwz/SfBJvgbQRTwHRGohnvU9gELWmwU/kP dTXDtu5DL7U2BInP48pr7dfIWP8EzQKQV8B75aGxMr1H4hLldw8CTJcb2PjHuBxIrkqnzw SVMspbG1cBVIBsd2YXO5IzXPlnai3Hu5uq+siLA5CoF22I2JX8K+jxyZgBe8rQ== X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id A9647C0013; Thu, 25 May 2023 12:44:00 +0000 (UTC) Date: Thu, 25 May 2023 14:43:59 +0200 From: Maxime Chevallier To: Simon Horman Cc: Mark Brown , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Russell King , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro Subject: Re: [PATCH net-next v2 1/4] net: mdio: Introduce a regmap-based mdio driver Message-ID: <20230525144359.0cb16996@pc-7.home> In-Reply-To: References: <20230525101126.370108-1-maxime.chevallier@bootlin.com> <20230525101126.370108-2-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230525_054410_985041_D94F7249 X-CRM114-Status: GOOD ( 23.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Simon, On Thu, 25 May 2023 13:02:39 +0200 Simon Horman wrote: > On Thu, May 25, 2023 at 12:11:23PM +0200, Maxime Chevallier wrote: > > There exists several examples today of devices that embed an > > ethernet PHY or PCS directly inside an SoC. In this situation, > > either the device is controlled through a vendor-specific register > > set, or sometimes exposes the standard 802.3 registers that are > > typically accessed over MDIO. > > > > As phylib and phylink are designed to use mdiodevices, this driver > > allows creating a virtual MDIO bus, that translates mdiodev register > > accesses to regmap accesses. > > > > The reason we use regmap is because there are at least 3 such > > devices known today, 2 of them are Altera TSE PCS's, memory-mapped, > > exposed with a 4-byte stride in stmmac's dwmac-socfpga variant, and > > a 2-byte stride in altera-tse. The other one > > (nxp,sja1110-base-tx-mdio) is exposed over SPI. > > > > Signed-off-by: Maxime Chevallier > > ... > > > +struct mii_bus *devm_mdio_regmap_register(struct device *dev, > > + const struct > > mdio_regmap_config *config) +{ > > + struct mdio_regmap_config *mrc; > > + struct mii_bus *mii; > > + int rc; > > + > > + if (!config->parent) > > + return ERR_PTR(-EINVAL); > > + > > + mii = devm_mdiobus_alloc_size(config->parent, > > sizeof(*mrc)); > > + if (!mii) > > + return ERR_PTR(-ENOMEM); > > + > > + mrc = mii->priv; > > + memcpy(mrc, config, sizeof(*mrc)); > > + > > + mrc->regmap = config->regmap; > > + mrc->valid_addr = config->valid_addr; > > + > > + mii->name = DRV_NAME; > > + strscpy(mii->id, config->name, MII_BUS_ID_SIZE); > > + mii->parent = config->parent; > > + mii->read = mdio_regmap_read_c22; > > + mii->write = mdio_regmap_write_c22; > > + > > + if (config->autoscan) > > + mii->phy_mask = ~BIT(config->valid_addr); > > + else > > + mii->phy_mask = ~0UL; > > Hi Maxime, > > phy_mask is a u32. > But 0UL may be either 32 or 64 bits wide. Right > I think a better approach would be to use U32_MAX. I guess ~0 would also work, and this would also align with what fixed-phy and sfp do for their internal MDIO bus. I'll fix that for next revision Thanks, Maxime > > + > > + rc = devm_mdiobus_register(dev, mii); > > + if (rc) { > > + dev_err(config->parent, "Cannot register MDIO > > bus![%s] (%d)\n", mii->id, rc); > > + return ERR_PTR(rc); > > + } > > + > > + return mii; > > +} > > +EXPORT_SYMBOL_GPL(devm_mdio_regmap_register); > > + > > +MODULE_DESCRIPTION("MDIO API over regmap"); > > +MODULE_AUTHOR("Maxime Chevallier "); > > +MODULE_LICENSE("GPL"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel