Re: [PATCH 5/5] dt-bindings: timer: atmel,at91rm9200-st: convert to yaml

Conor Dooley
2023-05-25T17:28:02Z

[-- Attachment #1.1: Type: text/plain, Size: 3654 bytes --]

On Thu, May 25, 2023 at 03:56:02PM +0300, Claudiu Beznea wrote:
> Convert Atmel system timer to YAML.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> .../devicetree/bindings/arm/atmel-sysregs.txt | 9 ---
> .../bindings/timer/atmel,at91rm9200-st.yaml | 66 +++++++++++++++++++
> 2 files changed, 66 insertions(+), 9 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/timer/atmel,at91rm9200-st.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> index 54d3f586403e..68c0eacb01ac 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> @@ -4,15 +4,6 @@ Chipid required properties:
> - compatible: Should be "atmel,sama5d2-chipid" or "microchip,sama7g5-chipid"
> - reg : Should contain registers location and length
>
> -System Timer (ST) required properties:
> -- compatible: Should be "atmel,at91rm9200-st", "syscon", "simple-mfd"
> -- reg: Should contain registers location and length
> -- interrupts: Should contain interrupt for the ST which is the IRQ line
> - shared across all System Controller members.
> -- clocks: phandle to input clock.
> -Its subnodes can be:
> -- watchdog: compatible should be "atmel,at91rm9200-wdt"
> -
> RAMC SDRAM/DDR Controller required properties:
> - compatible: Should be "atmel,at91rm9200-sdramc", "syscon"
> "atmel,at91sam9260-sdramc",
> diff --git a/Documentation/devicetree/bindings/timer/atmel,at91rm9200-st.yaml b/Documentation/devicetree/bindings/timer/atmel,at91rm9200-st.yaml
> new file mode 100644
> index 000000000000..08ee459d9fa3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/atmel,at91rm9200-st.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/atmel,at91rm9200-st.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel System Timer (ST)
> +
> +maintainers:
> + - Nicolas Ferre <nicolas.ferre@microchip.com>
> + - Alexandre Belloni <alexandre.belloni@microchip.com>
> + - Claudiu Beznea <claudiu.beznea@microchip.com>
> +
> +description:
> + Atmel system timer integrates a period interval timer, a watchdog timer and a
> + real-time timer.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - const: atmel,at91rm9200-st
> + - const: syscon
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description:
> + Contain interrupt for the ST which is the IRQ line shared across all
> + system controller members.
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + watchdog:
> + $ref: ../watchdog/atmel,at91rm9200-wdt.yaml
> + description:
> + Child node describing watchdog.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/at91.h>
> +
> + st: timer@fffffd00 {
> + compatible = "atmel,at91rm9200-st", "syscon", "simple-mfd";
> + reg = <0xfffffd00 0x100>;
> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;

This one is broken for the same reason too. Please test the bindings :(

Cheers,
Conor.

> + clocks = <&slow_xtal>;
> +
> + watchdog {
> + compatible = "atmel,at91rm9200-wdt";
> + };
> + };
> +
> +...
> --
> 2.34.1
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]