Re: [PATCH net-next 15/30] net: dsa: mt7530: set TRGMII RD TAP if trgmii is being used

Vladimir Oltean
2023-05-26T13:10:01Z

On Mon, May 22, 2023 at 03:15:17PM +0300, arinc9.unal@gmail.com wrote:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>
> This code sets the Read Data (RD) TAP value to 16 for all TRGMII control
> registers.
>
> The for loop iterates over all the TRGMII control registers, and
> mt7530_rmw() function is used to perform a read-modify-write operation on
> each register's RD_TAP field to set its value to 16.
>
> This operation is used to tune the timing of the read data signal in
> TRGMII to match the TX signal of the link partner.
>
> Run this if trgmii is being used. Since this code doesn't lower the
> driving, there's no apparent benefit to run this if trgmii is not being
> used.
>
> Add a comment to explain the code.
>
> Thanks to 趙皎宏 (Landen Chao) for pointing out what the code does.
>
> Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>