Re: [PATCH net-next 17/30] net: dsa: mt7530: fix port capabilities for MT7988

Vladimir Oltean
2023-05-26T13:20:51Z

On Mon, May 22, 2023 at 03:15:19PM +0300, arinc9.unal@gmail.com wrote:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>
> On the switch on the MT7988 SoC, there are only 4 PHYs. That's port 0 to 3.
> Set the internal phy cases to '0 ... 3'.
>
> There's no need to clear the config->supported_interfaces bitmap before
> reporting the supported interfaces as all bits in the bitmap will already
> be initialized to zero when the phylink_config structure is allocated.
> There's no code that would change the bitmap beforehand. Remove it.
>
> Fixes: 110c18bfed41 ("net: dsa: mt7530: introduce driver for MT7988 built-in switch")
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> Acked-by: Daniel Golle <daniel@makrotopia.org>
> ---

Either there is a user visible bug and in that case the patch needs to
go to the 'net' tree, or you need to drop the 'Fixes' tag.

Also, 2 separate logical changes => 2 patches please. Thanks.

> drivers/net/dsa/mt7530.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 514e82299537..f017cc028183 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -2533,10 +2533,8 @@ static void mt7531_mac_port_get_caps(struct dsa_switch *ds, int port,
> static void mt7988_mac_port_get_caps(struct dsa_switch *ds, int port,
> struct phylink_config *config)
> {
> - phy_interface_zero(config->supported_interfaces);
> -
> switch (port) {
> - case 0 ... 4: /* Internal phy */
> + case 0 ... 3: /* Internal phy */
> __set_bit(PHY_INTERFACE_MODE_INTERNAL,
> config->supported_interfaces);
> break;
> --
> 2.39.2