From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7698EC77B7E for ; Sat, 27 May 2023 07:41:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZipqBr/007idffDN+qPVaw+Ew78PcKkiDVrGjSLLZZo=; b=V3uK+MAJ8erQi4 HTA1FG7EsKxERFvPydI79JpDjElBn0crCv0VbkubY+AonT65ganNWTxCs6YhG3UtUnla4WuSIE327 yJUt6MhSUJV4YqBHpEBBUSlgQAqg3pvnC0Da9KRZrUiQg5cybp/731jTecg5XVbSVAgNRbckRWGib 6VAsp7kIU5GQZH03CZM9fyWsmH88EDNrBuFxuRvYv2C6iJNnsfMdi1gaPf00Eract3YILLWwFdSEK l30xXJ0j7fdhsl8dEJQAv/QiGYKHJKum/m1BcA0Ykdf8najoUDRkCTQYY32gEyxmKO0b12hxcnA0f azGxllLZggDRpzh8SWVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2oXs-0059jf-22; Sat, 27 May 2023 07:41:00 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2oXH-0059UX-1u for linux-arm-kernel@bombadil.infradead.org; Sat, 27 May 2023 07:40:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:To:From:Subject: References:Mime-Version:Message-Id:In-Reply-To:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cwNQ71nzWAtCurlrP6FCuEtDPR9XmwsHJykHXM8qing=; b=TVJwuhKzT1EbvGAlCJekg30iCb P+rEbE2YFJKoy/Dh5Z3YbhrruLLrmNrXr7k98lOUbKZIfUXZLoCYjyYWDj4HFtCTGso79VMkHDDM8 i8qErtTjWw3YebfKlM5oFw5+dg1b1zsaR7bD+bOslhh+X9g+hV4S2RBFx0TcqwlHQ1k6+rxytE1i0 rjdwNkI5aRN6AXU/OBrICzEu5zNEbuww3SVj9+nABlXObRU/+Q9mY5XpOhHZ9J2bYT2ZLwx7rkOEy AzK8T8J9O7gM1KTlp/lKBCaDlmSphp5d2JyUtq5W5YL3OvmzXGWbuipo/UIKUanTRBtnnY4v2tdKA Jbqp5h5g==; Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2oGi-009LjZ-08 for linux-arm-kernel@lists.infradead.org; Sat, 27 May 2023 07:23:51 +0000 Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1b00f70e6b0so17248095ad.0 for ; Sat, 27 May 2023 00:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685172190; x=1687764190; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=cwNQ71nzWAtCurlrP6FCuEtDPR9XmwsHJykHXM8qing=; b=lOmkzKB/CDHXV/rco7HS2RvubFjRAX64Al/x/EveVXU+0EEbRI8AWv2xMFWJhKQCtV /8zoblOYubNZ1ztF7yf55Ugp4qBvu02MYXnz9Rhu0yZ2ixeo0LoYzpzS5z4YIEH6N4Op sVCEH62LkRrUAc3vbKYQ+TJ6iZqsSpKFbAh86EEmY8fIdwlskwcUxW0fu/46vt+mV7lX JdwDskbPIfkzzyIGTjkOypbJrFnoEdZyfcfAQlloVlkHDMrVF1tFvSdKVokf/2gQqAY/ gXQDr+pOcntJtC7Odt3SiKE6CP1CUzqHWm1PpXA6VqAZjpNQTnSvxkFqjZ3Lshi7pnrx zgoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685172190; x=1687764190; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cwNQ71nzWAtCurlrP6FCuEtDPR9XmwsHJykHXM8qing=; b=Gy/aZw5jK3kjHIKlZCjKipIfrGg3sywEPxwRWQY+/+OwcQO95/G0T9XZvI1982Z6VQ H2eMi9W9oMBF+11eYZ+uxD2M/AMMCfvWgB8wgIX/Ln0jw9ke9SnlB4vgJ3c0HALSQVFK gfJIlei2pVDegB8ddkr3hYGeHK/n5KOCmJxQGFx4SXxs1XqH1lPGMqr0oMpJxIfWH/vU MYY3yr6lKhLW9l2HHuT4aH4NtpZKFw2i9F6yCSvIOzrwZgIwsdWehrSokbSlmFwvbbdn NlaQpHxY+HVvshfsGHQVgMNU6mgf5A3n309Ft5kYBW3u9wg3RVlv4L4YkhPqRKxpyxk7 qUWw== X-Gm-Message-State: AC+VfDymZxQiJjdEGgDxx4808rcVCOz6rnj41XG5zakDT3yFsofd+Utr G1va815YRXN1gXQ8+IY6Ahxf9yi/lLC+ X-Google-Smtp-Source: ACHHUZ7UV8GZgGYFzC4oxTs1TYELikiLvG9qg0wVWQ4EFn9Nb8epp081W/xOPomIVYFOAD5jMOcSUqzwfE1P X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:3b4e:312c:644:a642]) (user=irogers job=sendgmr) by 2002:a17:902:bb92:b0:1ad:e398:4477 with SMTP id m18-20020a170902bb9200b001ade3984477mr1200446pls.8.1685172190553; Sat, 27 May 2023 00:23:10 -0700 (PDT) Date: Sat, 27 May 2023 00:21:52 -0700 In-Reply-To: <20230527072210.2900565-1-irogers@google.com> Message-Id: <20230527072210.2900565-17-irogers@google.com> Mime-Version: 1.0 References: <20230527072210.2900565-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH v5 16/34] perf pmu: Rewrite perf_pmu__has_hybrid to avoid list From: Ian Rogers To: Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , James Clark , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kajol Jain , Jing Zhang , Kan Liang , Zhengjun Xing , Ravi Bangoria , Madhavan Srinivasan , Athira Rajeev , Ming Wang , Huacai Chen , Sandipan Das , Dmitrii Dolgov <9erthalion6@gmail.com>, Sean Christopherson , Ali Saidi , Rob Herring , Thomas Richter , Kang Minchul , linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230527_082339_481220_B79E4108 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rather than list empty on perf_pmu__hybrid_pmus, detect if any core PMUs match the hybrid name. Computed values held in statics to avoid recomputation. Signed-off-by: Ian Rogers Reviewed-by: Kan Liang --- tools/perf/util/pmu.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 83c7eeb8abea..5a7bfbf621d0 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -60,8 +60,6 @@ struct perf_pmu_format { struct list_head list; }; -static bool hybrid_scanned; - static struct perf_pmu *perf_pmu__find2(int dirfd, const char *name); /* @@ -2013,12 +2011,20 @@ void perf_pmu__warn_invalid_config(struct perf_pmu *pmu, __u64 config, bool perf_pmu__has_hybrid(void) { + static bool hybrid_scanned, has_hybrid; + if (!hybrid_scanned) { + struct perf_pmu *pmu = NULL; + + while ((pmu = perf_pmu__scan(pmu)) != NULL) { + if (pmu->is_core && is_pmu_hybrid(pmu->name)) { + has_hybrid = true; + break; + } + } hybrid_scanned = true; - perf_pmu__scan(NULL); } - - return !list_empty(&perf_pmu__hybrid_pmus); + return has_hybrid; } int perf_pmu__match(char *pattern, char *name, char *tok) -- 2.41.0.rc0.172.g3f132b7071-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel